Re: [PATCH] xfrm_user: return error pointer instead of NULL #2

2012-09-18 Thread David Miller
From: Steffen Klassert Date: Mon, 17 Sep 2012 09:18:53 +0200 > On Fri, Sep 14, 2012 at 09:58:32PM +0200, Mathias Krause wrote: >> When dump_one_policy() returns an error, e.g. because of a too small >> buffer to dump the whole xfrm policy, xfrm_policy_netlink() returns >> NULL instead of an error

Re: [PATCH] xfrm_user: return error pointer instead of NULL

2012-09-18 Thread David Miller
From: Steffen Klassert Date: Mon, 17 Sep 2012 09:16:42 +0200 > On Thu, Sep 13, 2012 at 11:41:26PM +0200, Mathias Krause wrote: >> When dump_one_state() returns an error, e.g. because of a too small >> buffer to dump the whole xfrm state, xfrm_state_netlink() returns NULL >> instead of an error po

Re: [PATCH] xfrm_user: return error pointer instead of NULL

2012-09-17 Thread Mathias Krause
On Mon, Sep 17, 2012 at 9:16 AM, Steffen Klassert wrote: > On Thu, Sep 13, 2012 at 11:41:26PM +0200, Mathias Krause wrote: >> When dump_one_state() returns an error, e.g. because of a too small >> buffer to dump the whole xfrm state, xfrm_state_netlink() returns NULL >> instead of an error pointer

Re: [PATCH] xfrm_user: return error pointer instead of NULL #2

2012-09-17 Thread Steffen Klassert
On Fri, Sep 14, 2012 at 09:58:32PM +0200, Mathias Krause wrote: > When dump_one_policy() returns an error, e.g. because of a too small > buffer to dump the whole xfrm policy, xfrm_policy_netlink() returns > NULL instead of an error pointer. But its caller expects an error > pointer and therefore co

Re: [PATCH] xfrm_user: return error pointer instead of NULL

2012-09-17 Thread Steffen Klassert
On Thu, Sep 13, 2012 at 11:41:26PM +0200, Mathias Krause wrote: > When dump_one_state() returns an error, e.g. because of a too small > buffer to dump the whole xfrm state, xfrm_state_netlink() returns NULL > instead of an error pointer. But its callers expect an error pointer > and therefore conti

[PATCH] xfrm_user: return error pointer instead of NULL #2

2012-09-14 Thread Mathias Krause
When dump_one_policy() returns an error, e.g. because of a too small buffer to dump the whole xfrm policy, xfrm_policy_netlink() returns NULL instead of an error pointer. But its caller expects an error pointer and therefore continues to operate on a NULL skbuff. Cc: sta...@vger.kernel.org Signed-

[PATCH] xfrm_user: return error pointer instead of NULL

2012-09-13 Thread Mathias Krause
When dump_one_state() returns an error, e.g. because of a too small buffer to dump the whole xfrm state, xfrm_state_netlink() returns NULL instead of an error pointer. But its callers expect an error pointer and therefore continue to operate on a NULL skbuff. This could lead to a privilege escalat