Re: [PATCH] xfs: Fix wrong error codes being returned

2014-04-22 Thread Jeff Liu
On 04/12 2014 22:36 PM, Brian Foster wrote: > On Mon, Apr 21, 2014 at 10:01:34PM +0800, Jeff Liu wrote: >> >> On 04/21 2014 21:09 PM, Brian Foster wrote: >>> On Mon, Apr 21, 2014 at 08:46:39PM +0800, Jeff Liu wrote: Hi Tuomas, On 04/21 2014 18:04 PM, Tuomas Tynkkynen wrote: > xf

Re: [PATCH] xfs: Fix wrong error codes being returned

2014-04-21 Thread Brian Foster
On Mon, Apr 21, 2014 at 10:01:34PM +0800, Jeff Liu wrote: > > On 04/21 2014 21:09 PM, Brian Foster wrote: > > On Mon, Apr 21, 2014 at 08:46:39PM +0800, Jeff Liu wrote: > >> Hi Tuomas, > >> > >> On 04/21 2014 18:04 PM, Tuomas Tynkkynen wrote: > >>> xfs_{compat_,}attrmulti_by_handle could return an

Re: [PATCH] xfs: Fix wrong error codes being returned

2014-04-21 Thread Jeff Liu
On 04/21 2014 21:09 PM, Brian Foster wrote: > On Mon, Apr 21, 2014 at 08:46:39PM +0800, Jeff Liu wrote: >> Hi Tuomas, >> >> On 04/21 2014 18:04 PM, Tuomas Tynkkynen wrote: >>> xfs_{compat_,}attrmulti_by_handle could return an errno with incorrect >>> sign in some cases. While at it, make sure ENOM

Re: [PATCH] xfs: Fix wrong error codes being returned

2014-04-21 Thread Brian Foster
On Mon, Apr 21, 2014 at 08:46:39PM +0800, Jeff Liu wrote: > Hi Tuomas, > > On 04/21 2014 18:04 PM, Tuomas Tynkkynen wrote: > > xfs_{compat_,}attrmulti_by_handle could return an errno with incorrect > > sign in some cases. While at it, make sure ENOMEM is returned instead of > > E2BIG if kmalloc fa

Re: [PATCH] xfs: Fix wrong error codes being returned

2014-04-21 Thread Brian Foster
On Mon, Apr 21, 2014 at 01:04:47PM +0300, Tuomas Tynkkynen wrote: > xfs_{compat_,}attrmulti_by_handle could return an errno with incorrect > sign in some cases. While at it, make sure ENOMEM is returned instead of > E2BIG if kmalloc fails. > > Signed-off-by: Tuomas Tynkkynen > --- The fix looks

Re: [PATCH] xfs: Fix wrong error codes being returned

2014-04-21 Thread Jeff Liu
Hi Tuomas, On 04/21 2014 18:04 PM, Tuomas Tynkkynen wrote: > xfs_{compat_,}attrmulti_by_handle could return an errno with incorrect > sign in some cases. While at it, make sure ENOMEM is returned instead of > E2BIG if kmalloc fails. > > Signed-off-by: Tuomas Tynkkynen > --- > Compile tested only

[PATCH] xfs: Fix wrong error codes being returned

2014-04-21 Thread Tuomas Tynkkynen
xfs_{compat_,}attrmulti_by_handle could return an errno with incorrect sign in some cases. While at it, make sure ENOMEM is returned instead of E2BIG if kmalloc fails. Signed-off-by: Tuomas Tynkkynen --- Compile tested only. For the ERANGE case, I also wonder if it should be assigning to ops[i].a