Re: [PATCH] xfs: fix return of uninitialized value in variable error

2021-04-09 Thread Darrick J. Wong
On Fri, Apr 09, 2021 at 03:18:34PM +0100, Colin King wrote: > From: Colin Ian King > > A previous commit removed a call to xfs_attr3_leaf_read that > assigned an error return code to variable error. We now have > a few early error return paths to label 'out' that return > error if error is set;

Re: [PATCH] xfs: fix return of uninitialized value in variable error

2021-04-09 Thread Colin Ian King
On 09/04/2021 15:28, Brian Foster wrote: > On Fri, Apr 09, 2021 at 03:18:34PM +0100, Colin King wrote: >> From: Colin Ian King >> >> A previous commit removed a call to xfs_attr3_leaf_read that >> assigned an error return code to variable error. We now have >> a few early error return paths to

Re: [PATCH] xfs: fix return of uninitialized value in variable error

2021-04-09 Thread Brian Foster
On Fri, Apr 09, 2021 at 03:18:34PM +0100, Colin King wrote: > From: Colin Ian King > > A previous commit removed a call to xfs_attr3_leaf_read that > assigned an error return code to variable error. We now have > a few early error return paths to label 'out' that return > error if error is set;

[PATCH] xfs: fix return of uninitialized value in variable error

2021-04-09 Thread Colin King
From: Colin Ian King A previous commit removed a call to xfs_attr3_leaf_read that assigned an error return code to variable error. We now have a few early error return paths to label 'out' that return error if error is set; however error now is uninitialized so potentially garbage is being