Re: [PATCH] xhci: Make debug message consistent with bus and port number

2020-06-30 Thread Mathias Nyman
On 30.6.2020 14.46, Kai-Heng Feng wrote: > >> >> Added to my for-usb-next branch, (which I'll need to rebase on 5.8-rc1 once >> released) > > Hmm, not seeing this patch from mainline, next or xhci tree.. > Apparently I never pushed it to kernel.org, now it should be in my for-usb-next branch

Re: [PATCH] xhci: Make debug message consistent with bus and port number

2020-06-30 Thread Kai-Heng Feng
> On Jun 8, 2020, at 17:29, Mathias Nyman wrote: > > On 8.6.2020 6.57, Kai-Heng Feng wrote: >> >> >>> On May 7, 2020, at 18:35, Mathias Nyman >>> wrote: >>> >>> On 7.5.2020 11.21, Greg Kroah-Hartman wrote: On Thu, May 07, 2020 at 03:58:36PM +0800, Kai-Heng Feng wrote: > >

Re: [PATCH] xhci: Make debug message consistent with bus and port number

2020-06-08 Thread Mathias Nyman
On 8.6.2020 6.57, Kai-Heng Feng wrote: > > >> On May 7, 2020, at 18:35, Mathias Nyman >> wrote: >> >> On 7.5.2020 11.21, Greg Kroah-Hartman wrote: >>> On Thu, May 07, 2020 at 03:58:36PM +0800, Kai-Heng Feng wrote: > On May 7, 2020, at 15:31, Greg Kroah-Hartman > wrote:

Re: [PATCH] xhci: Make debug message consistent with bus and port number

2020-06-07 Thread Kai-Heng Feng
> On May 7, 2020, at 18:35, Mathias Nyman wrote: > > On 7.5.2020 11.21, Greg Kroah-Hartman wrote: >> On Thu, May 07, 2020 at 03:58:36PM +0800, Kai-Heng Feng wrote: >>> >>> On May 7, 2020, at 15:31, Greg Kroah-Hartman wrote: On Thu, May 07, 2020 at 03:15:01PM +0800,

Re: [PATCH] xhci: Make debug message consistent with bus and port number

2020-05-07 Thread Mathias Nyman
On 7.5.2020 11.21, Greg Kroah-Hartman wrote: > On Thu, May 07, 2020 at 03:58:36PM +0800, Kai-Heng Feng wrote: >> >> >>> On May 7, 2020, at 15:31, Greg Kroah-Hartman >>> wrote: >>> >>> On Thu, May 07, 2020 at 03:15:01PM +0800, Kai-Heng Feng wrote: > On May 7, 2020, at 14:45, Greg

Re: [PATCH] xhci: Make debug message consistent with bus and port number

2020-05-07 Thread Greg Kroah-Hartman
On Thu, May 07, 2020 at 03:58:36PM +0800, Kai-Heng Feng wrote: > > > > On May 7, 2020, at 15:31, Greg Kroah-Hartman > > wrote: > > > > On Thu, May 07, 2020 at 03:15:01PM +0800, Kai-Heng Feng wrote: > >> > >> > >>> On May 7, 2020, at 14:45, Greg Kroah-Hartman > >>> wrote: > >>> > >>> On

Re: [PATCH] xhci: Make debug message consistent with bus and port number

2020-05-07 Thread Kai-Heng Feng
> On May 7, 2020, at 15:31, Greg Kroah-Hartman > wrote: > > On Thu, May 07, 2020 at 03:15:01PM +0800, Kai-Heng Feng wrote: >> >> >>> On May 7, 2020, at 14:45, Greg Kroah-Hartman >>> wrote: >>> >>> On Thu, May 07, 2020 at 02:17:55PM +0800, Kai-Heng Feng wrote: Current xhci debug

Re: [PATCH] xhci: Make debug message consistent with bus and port number

2020-05-07 Thread Greg Kroah-Hartman
On Thu, May 07, 2020 at 03:15:01PM +0800, Kai-Heng Feng wrote: > > > > On May 7, 2020, at 14:45, Greg Kroah-Hartman > > wrote: > > > > On Thu, May 07, 2020 at 02:17:55PM +0800, Kai-Heng Feng wrote: > >> Current xhci debug message doesn't always output bus number, so it's > >> hard to figure

Re: [PATCH] xhci: Make debug message consistent with bus and port number

2020-05-07 Thread Kai-Heng Feng
> On May 7, 2020, at 14:45, Greg Kroah-Hartman > wrote: > > On Thu, May 07, 2020 at 02:17:55PM +0800, Kai-Heng Feng wrote: >> Current xhci debug message doesn't always output bus number, so it's >> hard to figure out it's from USB2 or USB3 root hub. >> >> In addition to that, some port

Re: [PATCH] xhci: Make debug message consistent with bus and port number

2020-05-07 Thread Greg Kroah-Hartman
On Thu, May 07, 2020 at 02:17:55PM +0800, Kai-Heng Feng wrote: > Current xhci debug message doesn't always output bus number, so it's > hard to figure out it's from USB2 or USB3 root hub. > > In addition to that, some port numbers are offset to 0 and others are > offset to 1. Use the latter to

[PATCH] xhci: Make debug message consistent with bus and port number

2020-05-07 Thread Kai-Heng Feng
Current xhci debug message doesn't always output bus number, so it's hard to figure out it's from USB2 or USB3 root hub. In addition to that, some port numbers are offset to 0 and others are offset to 1. Use the latter to match the USB core. So use "bus number - port index + 1" to make debug