Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown

2021-02-21 Thread Kai-Heng Feng
On Fri, Feb 19, 2021 at 4:07 PM Aaron Ma wrote: > > > > On 2/11/21 8:50 PM, Greg Kroah-Hartman wrote: > > On Wed, Feb 10, 2021 at 03:13:30PM +0200, Mathias Nyman wrote: > >> On 9.2.2021 10.37, Greg Kroah-Hartman wrote: > >>> On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote: > On

Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown

2021-02-19 Thread Aaron Ma
On 2/11/21 8:50 PM, Greg Kroah-Hartman wrote: On Wed, Feb 10, 2021 at 03:13:30PM +0200, Mathias Nyman wrote: On 9.2.2021 10.37, Greg Kroah-Hartman wrote: On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote: On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma wrote: On 2/5/21 12:27 PM,

Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown

2021-02-11 Thread Greg Kroah-Hartman
On Wed, Feb 10, 2021 at 03:13:30PM +0200, Mathias Nyman wrote: > On 9.2.2021 10.37, Greg Kroah-Hartman wrote: > > On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote: > >> On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma wrote: > >>> > >>> > >>> On 2/5/21 12:27 PM, Kai-Heng Feng wrote: >

Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown

2021-02-10 Thread Mathias Nyman
On 9.2.2021 10.37, Greg Kroah-Hartman wrote: > On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote: >> On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma wrote: >>> >>> >>> On 2/5/21 12:27 PM, Kai-Heng Feng wrote: Can you please test the following patch, which should address the root

Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown

2021-02-09 Thread Greg Kroah-Hartman
On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote: > On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma wrote: > > > > > > On 2/5/21 12:27 PM, Kai-Heng Feng wrote: > > > Can you please test the following patch, which should address the root > > > cause: > > >

Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown

2021-02-04 Thread Kai-Heng Feng
On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma wrote: > > > On 2/5/21 12:27 PM, Kai-Heng Feng wrote: > > Can you please test the following patch, which should address the root > > cause: > > https://lore.kernel.org/linux-acpi/20201201213019.1558738-1-furq...@google.com/ > > > > It also helps another

Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown

2021-02-04 Thread Aaron Ma
On 2/5/21 12:27 PM, Kai-Heng Feng wrote: Can you please test the following patch, which should address the root cause: https://lore.kernel.org/linux-acpi/20201201213019.1558738-1-furq...@google.com/ It also helps another AMD laptop on S5:

Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown

2021-02-04 Thread Kai-Heng Feng
On Thu, Feb 4, 2021 at 1:20 PM Aaron Ma wrote: > > On AMD Renoir/Cezanne platforms, when set "Always on USB" to "On" in BIOS, > USB controller will consume more power than 0.03w. > > Set it to D3cold when shutdown, S5 power consumption will be 0.03w lower. > The USB can charge other devices as

[PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown

2021-02-03 Thread Aaron Ma
On AMD Renoir/Cezanne platforms, when set "Always on USB" to "On" in BIOS, USB controller will consume more power than 0.03w. Set it to D3cold when shutdown, S5 power consumption will be 0.03w lower. The USB can charge other devices as before. USB controller works fine after power on and reboot.