Re: [PATCH] xillybus: XILLYBUS_OF should depend on HAS_DMA

On 24/04/15 15:58, Geert Uytterhoeven wrote: Can I add your Acked-by, then I can send an updated version to Greg and Arnd? Yes, indeed. Thanks. Eli -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH] xillybus: XILLYBUS_OF should depend on HAS_DMA

Hi Eli, On Fri, Apr 24, 2015 at 2:42 PM, Eli Billauer wrote: > Thanks for this. The dependency on HAS_DMA is obviously missing (is there > any real platform that uses OF but has HAS_DMA off? Sounds a bit esoteric to > me). I hit this with the patch that allows to enable OF if COMPILE_TEST, which

Re: [PATCH] xillybus: XILLYBUS_OF should depend on HAS_DMA

Hello Geert, Thanks for this. The dependency on HAS_DMA is obviously missing (is there any real platform that uses OF but has HAS_DMA off? Sounds a bit esoteric to me). And if we're at it, I now realize that XILLYBUS_PCIE maybe also should depend on HAS_DMA, in case PCI is enabled but HAS_DM

[PATCH] xillybus: XILLYBUS_OF should depend on HAS_DMA

If NO_DMA=y: drivers/built-in.o: In function `xilly_of_unmap': xillybus_of.c:(.text+0xa860e): undefined reference to `dma_unmap_single' drivers/built-in.o: In function `xilly_map_single_of': xillybus_of.c:(.text+0xa8668): undefined reference to `dma_map_single' xillybus_of.c:(.