Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-21 Thread Heiko Carstens
On Thu, Feb 21, 2019 at 01:12:40PM +0100, Cornelia Huck wrote: > On Thu, 21 Feb 2019 11:42:25 +0100 > Harald Freudenberger wrote: > > > On 30.01.19 19:32, Sebastian Ott wrote: > > > On Wed, 30 Jan 2019, Tony Krowiak wrote: > > > >> /* > > >> +* A config change has happened, Force an ap bus

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-21 Thread Cornelia Huck
On Thu, 21 Feb 2019 11:42:25 +0100 Harald Freudenberger wrote: > On 30.01.19 19:32, Sebastian Ott wrote: > > On Wed, 30 Jan 2019, Tony Krowiak wrote: > >> /* > >> +* A config change has happened, Force an ap bus rescan. > >> +*/ > >> +void ap_bus_cfg_chg(void) > >> +{ > >> +

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-21 Thread Harald Freudenberger
On 30.01.19 19:32, Sebastian Ott wrote: > On Wed, 30 Jan 2019, Tony Krowiak wrote: >> +#if IS_ENABLED(CONFIG_ZCRYPT) >> +void ap_bus_cfg_chg(void); >> +#else >> +#error "no CONFIG_ZCRYPT" >^ > I don't think that's the right thing to do here. > > >> +++ b/drivers/s390/cio/chsc.h >> @@ -9,6 +9,7

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-05 Thread Tony Krowiak
On 2/4/19 5:15 AM, Harald Freudenberger wrote: On 01.02.19 15:35, Cornelia Huck wrote: On Thu, 31 Jan 2019 18:50:57 -0500 Tony Krowiak wrote: On 1/31/19 4:55 AM, Cornelia Huck wrote: On Wed, 30 Jan 2019 12:48:46 -0500 Tony Krowiak wrote: Two questions: - Does the event cover _any_ change

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-05 Thread Tony Krowiak
On 2/4/19 5:01 AM, Sebastian Ott wrote: On Thu, 31 Jan 2019, Tony Krowiak wrote: On 1/30/19 1:32 PM, Sebastian Ott wrote: On Wed, 30 Jan 2019, Tony Krowiak wrote: +++ b/drivers/s390/cio/chsc.h @@ -9,6 +9,7 @@ #include #include #include +#include This should be moved to chsc.c

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-05 Thread Tony Krowiak
On 2/4/19 5:06 AM, Harald Freudenberger wrote: On 01.02.19 16:38, Tony Krowiak wrote: On 2/1/19 4:01 AM, Heiko Carstens wrote: On Thu, Jan 31, 2019 at 06:28:39PM -0500, Tony Krowiak wrote: On 1/30/19 1:32 PM, Sebastian Ott wrote: On Wed, 30 Jan 2019, Tony Krowiak wrote: +#if

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-04 Thread Cornelia Huck
On Mon, 4 Feb 2019 11:15:25 +0100 Harald Freudenberger wrote: > On 01.02.19 15:35, Cornelia Huck wrote: > > On Thu, 31 Jan 2019 18:50:57 -0500 > > Tony Krowiak wrote: > > > >> On 1/31/19 4:55 AM, Cornelia Huck wrote: > >>> On Wed, 30 Jan 2019 12:48:46 -0500 > >>> Tony Krowiak wrote: > >>>

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-04 Thread Harald Freudenberger
On 01.02.19 15:35, Cornelia Huck wrote: > On Thu, 31 Jan 2019 18:50:57 -0500 > Tony Krowiak wrote: > >> On 1/31/19 4:55 AM, Cornelia Huck wrote: >>> On Wed, 30 Jan 2019 12:48:46 -0500 >>> Tony Krowiak wrote: >>> Two questions: >>> - Does the event cover _any_ change to the AP configuration, or

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-04 Thread Harald Freudenberger
On 01.02.19 16:38, Tony Krowiak wrote: > On 2/1/19 4:01 AM, Heiko Carstens wrote: >> On Thu, Jan 31, 2019 at 06:28:39PM -0500, Tony Krowiak wrote: >>> On 1/30/19 1:32 PM, Sebastian Ott wrote: On Wed, 30 Jan 2019, Tony Krowiak wrote: > +#if IS_ENABLED(CONFIG_ZCRYPT) > +void

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-04 Thread Sebastian Ott
On Thu, 31 Jan 2019, Tony Krowiak wrote: > On 1/30/19 1:32 PM, Sebastian Ott wrote: > > On Wed, 30 Jan 2019, Tony Krowiak wrote: > >> +++ b/drivers/s390/cio/chsc.h > >> @@ -9,6 +9,7 @@ > >> #include > >> #include > >> #include > >> +#include > > > > This should be moved to chsc.c > > I

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-03 Thread kbuild test robot
Hi Tony, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc4 next-20190201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-01 Thread Tony Krowiak
On 2/1/19 9:35 AM, Cornelia Huck wrote: On Thu, 31 Jan 2019 18:50:57 -0500 Tony Krowiak wrote: On 1/31/19 4:55 AM, Cornelia Huck wrote: On Wed, 30 Jan 2019 12:48:46 -0500 Tony Krowiak wrote: Two questions: - Does the event cover _any_ change to the AP configuration, or can the

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-01 Thread Tony Krowiak
On 2/1/19 8:05 AM, Heiko Carstens wrote: On Fri, Feb 01, 2019 at 10:01:59AM +0100, Heiko Carstens wrote: On Thu, Jan 31, 2019 at 06:28:39PM -0500, Tony Krowiak wrote: On 1/30/19 1:32 PM, Sebastian Ott wrote: On Wed, 30 Jan 2019, Tony Krowiak wrote: +#if IS_ENABLED(CONFIG_ZCRYPT) +void

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-01 Thread Tony Krowiak
On 2/1/19 4:01 AM, Heiko Carstens wrote: On Thu, Jan 31, 2019 at 06:28:39PM -0500, Tony Krowiak wrote: On 1/30/19 1:32 PM, Sebastian Ott wrote: On Wed, 30 Jan 2019, Tony Krowiak wrote: +#if IS_ENABLED(CONFIG_ZCRYPT) +void ap_bus_cfg_chg(void); +#else +#error "no CONFIG_ZCRYPT" ^ I don't

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-01 Thread Cornelia Huck
On Thu, 31 Jan 2019 18:50:57 -0500 Tony Krowiak wrote: > On 1/31/19 4:55 AM, Cornelia Huck wrote: > > On Wed, 30 Jan 2019 12:48:46 -0500 > > Tony Krowiak wrote: > > Two questions: > > - Does the event cover _any_ change to the AP configuration, or can the > >periodic scan detect changes

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-01 Thread Heiko Carstens
On Fri, Feb 01, 2019 at 10:01:59AM +0100, Heiko Carstens wrote: > On Thu, Jan 31, 2019 at 06:28:39PM -0500, Tony Krowiak wrote: > > On 1/30/19 1:32 PM, Sebastian Ott wrote: > > >On Wed, 30 Jan 2019, Tony Krowiak wrote: > > >>+#if IS_ENABLED(CONFIG_ZCRYPT) > > >>+void ap_bus_cfg_chg(void); ... >

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-01 Thread Martin Schwidefsky
On Fri, 1 Feb 2019 10:01:59 +0100 Heiko Carstens wrote: > On Thu, Jan 31, 2019 at 06:28:39PM -0500, Tony Krowiak wrote: > > On 1/30/19 1:32 PM, Sebastian Ott wrote: > > >On Wed, 30 Jan 2019, Tony Krowiak wrote: > > >>+#if IS_ENABLED(CONFIG_ZCRYPT) > > >>+void ap_bus_cfg_chg(void); > >

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-01 Thread Heiko Carstens
On Thu, Jan 31, 2019 at 06:28:39PM -0500, Tony Krowiak wrote: > On 1/30/19 1:32 PM, Sebastian Ott wrote: > >On Wed, 30 Jan 2019, Tony Krowiak wrote: > >>+#if IS_ENABLED(CONFIG_ZCRYPT) > >>+void ap_bus_cfg_chg(void); > >>+#else > >>+#error "no CONFIG_ZCRYPT" > >^ > >I don't think that's the

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-01-31 Thread Tony Krowiak
On 1/31/19 4:55 AM, Cornelia Huck wrote: On Wed, 30 Jan 2019 12:48:46 -0500 Tony Krowiak wrote: The current AP bus implementation periodically polls the AP configuration to detect changes. When the AP configuration is dynamically changed via the SE or an SCLP instruction, the changes will not

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-01-31 Thread Tony Krowiak
On 1/31/19 4:09 AM, Pierre Morel wrote: On 30/01/2019 18:48, Tony Krowiak wrote: The current AP bus implementation periodically polls the AP configuration to detect changes. When the AP configuration is dynamically changed via the SE or an SCLP instruction, the changes will not be reflected to

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-01-31 Thread Tony Krowiak
On 1/30/19 1:32 PM, Sebastian Ott wrote: On Wed, 30 Jan 2019, Tony Krowiak wrote: +#if IS_ENABLED(CONFIG_ZCRYPT) +void ap_bus_cfg_chg(void); +#else +#error "no CONFIG_ZCRYPT" ^ I don't think that's the right thing to do here. I'd like to leave it. If somebody edits .config and sets

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-01-31 Thread Cornelia Huck
On Wed, 30 Jan 2019 12:48:46 -0500 Tony Krowiak wrote: > The current AP bus implementation periodically polls the AP configuration > to detect changes. When the AP configuration is dynamically changed via the > SE or an SCLP instruction, the changes will not be reflected to sysfs until > the

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-01-31 Thread Pierre Morel
On 30/01/2019 18:48, Tony Krowiak wrote: The current AP bus implementation periodically polls the AP configuration to detect changes. When the AP configuration is dynamically changed via the SE or an SCLP instruction, the changes will not be reflected to sysfs until the next time the AP

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-01-31 Thread Pierre Morel
On 30/01/2019 18:48, Tony Krowiak wrote: The current AP bus implementation periodically polls the AP configuration to detect changes. When the AP configuration is dynamically changed via the SE or an SCLP instruction, the changes will not be reflected to sysfs until the next time the AP

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-01-30 Thread Sebastian Ott
On Wed, 30 Jan 2019, Tony Krowiak wrote: > +#if IS_ENABLED(CONFIG_ZCRYPT) > +void ap_bus_cfg_chg(void); > +#else > +#error "no CONFIG_ZCRYPT" ^ I don't think that's the right thing to do here. > +++ b/drivers/s390/cio/chsc.h > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include

[PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-01-30 Thread Tony Krowiak
The current AP bus implementation periodically polls the AP configuration to detect changes. When the AP configuration is dynamically changed via the SE or an SCLP instruction, the changes will not be reflected to sysfs until the next time the AP configuration is polled. The CHSC architecture