RE: [PATCH] zlib: define get_unaligned16() only when used

2020-11-24 Thread David Laight
From: Arnd Bergmann > Sent: 24 November 2020 11:57 > > On Tue, Nov 24, 2020 at 12:51 PM Christoph Hellwig wrote: > > On Tue, Nov 24, 2020 at 12:08:40PM +0100, Jann Horn wrote: > > > > Since commit acaab7335bd6 ("lib/zlib: remove outdated and incorrect > > > > pre-increment optimization"), get_una

Re: [PATCH] zlib: define get_unaligned16() only when used

2020-11-24 Thread Lukas Bulwahn
On Tue, Nov 24, 2020 at 12:56 PM Arnd Bergmann wrote: > > On Tue, Nov 24, 2020 at 12:51 PM Christoph Hellwig wrote: > > On Tue, Nov 24, 2020 at 12:08:40PM +0100, Jann Horn wrote: > > > > Since commit acaab7335bd6 ("lib/zlib: remove outdated and incorrect > > > > pre-increment optimization"), get_

Re: [PATCH] zlib: define get_unaligned16() only when used

2020-11-24 Thread Arnd Bergmann
On Tue, Nov 24, 2020 at 12:51 PM Christoph Hellwig wrote: > On Tue, Nov 24, 2020 at 12:08:40PM +0100, Jann Horn wrote: > > > Since commit acaab7335bd6 ("lib/zlib: remove outdated and incorrect > > > pre-increment optimization"), get_unaligned16() is only used when > > > !CONFIG_HAVE_EFFICIENT_UNAL

Re: [PATCH] zlib: define get_unaligned16() only when used

2020-11-24 Thread Christoph Hellwig
On Tue, Nov 24, 2020 at 12:08:40PM +0100, Jann Horn wrote: > > Since commit acaab7335bd6 ("lib/zlib: remove outdated and incorrect > > pre-increment optimization"), get_unaligned16() is only used when > > !CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. > > > > Hence, make CC=clang W=1 warns: > > > > lib

Re: [PATCH] zlib: define get_unaligned16() only when used

2020-11-24 Thread Jann Horn
On Tue, Nov 24, 2020 at 11:40 AM Lukas Bulwahn wrote: > Since commit acaab7335bd6 ("lib/zlib: remove outdated and incorrect > pre-increment optimization"), get_unaligned16() is only used when > !CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. > > Hence, make CC=clang W=1 warns: > > lib/zlib_inflate/inff

[PATCH] zlib: define get_unaligned16() only when used

2020-11-24 Thread Lukas Bulwahn
Since commit acaab7335bd6 ("lib/zlib: remove outdated and incorrect pre-increment optimization"), get_unaligned16() is only used when !CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. Hence, make CC=clang W=1 warns: lib/zlib_inflate/inffast.c:20:1: warning: unused function 'get_unaligned16' [-Wunuse