Re: [PATCH] zram: rely on the bi_end_io for zram_rw_page fails

2014-11-19 Thread Minchan Kim
Hello, On Wed, Nov 19, 2014 at 01:15:35PM -0800, Andrew Morton wrote: > On Wed, 19 Nov 2014 08:52:01 +0900 Minchan Kim wrote: > > > > > > > > > - /* > > > > -* Return 0 prevents I/O fallback trial caused by rw_page fail > > > > -* and upper layer can handle this IO error

Re: [PATCH] zram: rely on the bi_end_io for zram_rw_page fails

2014-11-19 Thread Andrew Morton
On Wed, 19 Nov 2014 08:52:01 +0900 Minchan Kim wrote: > > > > > > - /* > > > - * Return 0 prevents I/O fallback trial caused by rw_page fail > > > - * and upper layer can handle this IO error via page error. > > > - */ > > > + page_endio(page, rw, 0); > > > return 0; > > > > Losing the co

Re: [PATCH] zram: rely on the bi_end_io for zram_rw_page fails

2014-11-18 Thread Minchan Kim
On Tue, Nov 18, 2014 at 03:23:36PM -0800, Andrew Morton wrote: > On Fri, 14 Nov 2014 09:49:07 +0900 Minchan Kim wrote: > > > When I tested zram, I found processes got segfaulted. > > The reason was zram_rw_page doesn't make the page dirty > > again when swap write failed, and even it doesn't retu

Re: [PATCH] zram: rely on the bi_end_io for zram_rw_page fails

2014-11-18 Thread Andrew Morton
On Fri, 14 Nov 2014 09:49:07 +0900 Minchan Kim wrote: > When I tested zram, I found processes got segfaulted. > The reason was zram_rw_page doesn't make the page dirty > again when swap write failed, and even it doesn't return > error by [1]. > > If error by zram internal happens, zram_rw_page s

Re: [PATCH] zram: rely on the bi_end_io for zram_rw_page fails

2014-11-15 Thread Sergey Senozhatsky
Hi, On (11/14/14 09:49), Minchan Kim wrote: > When I tested zram, I found processes got segfaulted. > The reason was zram_rw_page doesn't make the page dirty > again when swap write failed, and even it doesn't return > error by [1]. > > If error by zram internal happens, zram_rw_page should retur

[PATCH] zram: rely on the bi_end_io for zram_rw_page fails

2014-11-13 Thread Minchan Kim
When I tested zram, I found processes got segfaulted. The reason was zram_rw_page doesn't make the page dirty again when swap write failed, and even it doesn't return error by [1]. If error by zram internal happens, zram_rw_page should return non-zero without calling page_endio. It causes resubmit