Re: [PATCH]optimize error handling in tick_check_new_device

2016-07-28 Thread Thomas Gleixner
On Wed, 27 Jul 2016, Gaurav Jindal (Gaurav Jindal) wrote: > In the function tick_check_new_device, module error is handled after checking > if the newdev should go as broadcast-installation device in the functions > tick_check_percpu and tick_check_preferred. In case the try_module_get returns > fa

Re: [PATCH]optimize error handling in tick_check_new_device

2016-07-27 Thread Nicolai Stange
"Gaurav Jindal (Gaurav Jindal)" writes: > diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c > index 4fcd99e..23faf4a 100644 > --- a/kernel/time/tick-common.c > +++ b/kernel/time/tick-common.c > @@ -307,6 +307,9 @@ void tick_check_new_device(struct clock_event_device > *newdev) >

[PATCH]optimize error handling in tick_check_new_device

2016-07-27 Thread Gaurav Jindal (Gaurav Jindal)
In the function tick_check_new_device, module error is handled after checking if the newdev should go as broadcast-installation device in the functions tick_check_percpu and tick_check_preferred. In case the try_module_get returns false, the above 2 calls are extra thus wasting CPU cycles. Shiftin