Re: [PATCH-next] init/main.c: make local symbol static

2018-01-18 Thread Steven Rostedt
On Thu, 18 Jan 2018 18:33:27 -0500 Christopher Díaz Riveros wrote: > > > What about the other user(s) of envp_init? > > > > It looks like it's referenced in init/do_mounts_initrd.c. Rather > > than making it static, it should be declared in .h file. > > > > Ok, I'll try to figure it out,

Re: [PATCH-next] init/main.c: make local symbol static

2018-01-18 Thread Randy Dunlap
On 01/18/2018 03:33 PM, Christopher Díaz Riveros wrote: > El jue, 18-01-2018 a las 16:31 -0600, Tom Lendacky escribió: >> On 1/18/2018 4:09 PM, Randy Dunlap wrote: >>> On 01/18/2018 02:06 PM, Christopher Díaz Riveros wrote: Fixes the following sparse warning: init/main.c:167:12: warn

Re: [PATCH-next] init/main.c: make local symbol static

2018-01-18 Thread Christopher Díaz Riveros
El jue, 18-01-2018 a las 16:31 -0600, Tom Lendacky escribió: > On 1/18/2018 4:09 PM, Randy Dunlap wrote: > > On 01/18/2018 02:06 PM, Christopher Díaz Riveros wrote: > > > Fixes the following sparse warning: > > > > > > init/main.c:167:12: warning: > > > symbol 'envp_init' was not declared. Shoul

Re: [PATCH-next] init/main.c: make local symbol static

2018-01-18 Thread Tom Lendacky
On 1/18/2018 4:09 PM, Randy Dunlap wrote: > On 01/18/2018 02:06 PM, Christopher Díaz Riveros wrote: >> Fixes the following sparse warning: >> >> init/main.c:167:12: warning: >> symbol 'envp_init' was not declared. Should it be static? >> >> Signed-off-by: Christopher Díaz Riveros > > Does the k

Re: [PATCH-next] init/main.c: make local symbol static

2018-01-18 Thread Randy Dunlap
On 01/18/2018 02:06 PM, Christopher Díaz Riveros wrote: > Fixes the following sparse warning: > > init/main.c:167:12: warning: > symbol 'envp_init' was not declared. Should it be static? > > Signed-off-by: Christopher Díaz Riveros Does the kernel build OK after this change? What about the ot

[PATCH-next] init/main.c: make local symbol static

2018-01-18 Thread Christopher Díaz Riveros
Fixes the following sparse warning: init/main.c:167:12: warning: symbol 'envp_init' was not declared. Should it be static? Signed-off-by: Christopher Díaz Riveros --- init/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/main.c b/init/main.c index a8100b954839..