Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-16 Thread Ingo Molnar
* Waiman Long wrote: > > It can be seen that a lot more readers got the lock via optimistic > > spinning.  One possibility is that reader optimistic spinning causes > > readers to spread out into more lock acquisition groups than without. The > > K3 results show that grouping more readers into

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-15 Thread Waiman Long
On 04/12/2019 10:24 PM, Waiman Long wrote: > On 04/12/2019 02:05 PM, Waiman Long wrote: > >>> [locking/rwsem] adc32e8877: will-it-scale.per_thread_ops -21.0% regression >> Will look into that also. > I can reproduce the regression on the same skylake system. > > The results of the page_fault1 will

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-12 Thread Waiman Long
On 04/12/2019 02:05 PM, Waiman Long wrote: > On 04/12/2019 12:41 PM, Ingo Molnar wrote: >> >> So beyond the primary constraint of PeterZ OK-ing it all, there's also >> these two scalability regression reports from the ktest bot: >> >> [locking/rwsem] 1b94536f2d: stress-ng.bad-altstack.ops_per_sec

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-12 Thread Peter Zijlstra
On Fri, Apr 12, 2019 at 10:22:20AM -0400, Waiman Long wrote: > Oh, I see that the WIP.locking/core is currently merged into master. I > would say rwsem part1 patchset and patch 1 of part2 are stable. So I > would suggest merging those into the the master will be good. The rests > are still under re

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-12 Thread Waiman Long
On 04/12/2019 12:41 PM, Ingo Molnar wrote: > * Waiman Long wrote: > >>> BTW, the v3 patch that I posted yesterday should work fine as long as >>> CONFIG_RWSEM_SPIN_ON_OWNER is defined. >>> >>> Cheers, >>> Longman >>> >> Oh, I see that the WIP.locking/core is currently merged into master. I >> woul

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-12 Thread Ingo Molnar
* Waiman Long wrote: > > BTW, the v3 patch that I posted yesterday should work fine as long as > > CONFIG_RWSEM_SPIN_ON_OWNER is defined. > > > > Cheers, > > Longman > > > Oh, I see that the WIP.locking/core is currently merged into master. I > would say rwsem part1 patchset and patch 1 of part

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-12 Thread Waiman Long
On 04/12/2019 10:07 AM, Waiman Long wrote: > On 04/12/2019 10:04 AM, Waiman Long wrote: >> On 04/12/2019 03:09 AM, Ingo Molnar wrote: >>> * Peter Zijlstra wrote: >>> On Fri, Apr 12, 2019 at 09:02:09AM +0200, Ingo Molnar wrote: > * Waiman Long wrote: > >> On 04/11/2019 04:12 AM, P

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-12 Thread Waiman Long
On 04/12/2019 10:04 AM, Waiman Long wrote: > On 04/12/2019 03:09 AM, Ingo Molnar wrote: >> * Peter Zijlstra wrote: >> >>> On Fri, Apr 12, 2019 at 09:02:09AM +0200, Ingo Molnar wrote: * Waiman Long wrote: > On 04/11/2019 04:12 AM, Peter Zijlstra wrote: >> On Wed, Apr 10, 2019 at

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-12 Thread Waiman Long
On 04/12/2019 03:09 AM, Ingo Molnar wrote: > * Peter Zijlstra wrote: > >> On Fri, Apr 12, 2019 at 09:02:09AM +0200, Ingo Molnar wrote: >>> * Waiman Long wrote: >>> On 04/11/2019 04:12 AM, Peter Zijlstra wrote: > On Wed, Apr 10, 2019 at 02:42:19PM -0400, Waiman Long wrote: >> The owne

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-12 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Fri, Apr 12, 2019 at 09:02:09AM +0200, Ingo Molnar wrote: > > > > * Waiman Long wrote: > > > > > On 04/11/2019 04:12 AM, Peter Zijlstra wrote: > > > > On Wed, Apr 10, 2019 at 02:42:19PM -0400, Waiman Long wrote: > > > >> The owner field in the rw_semaphore struct

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-12 Thread Peter Zijlstra
On Fri, Apr 12, 2019 at 09:02:09AM +0200, Ingo Molnar wrote: > > * Waiman Long wrote: > > > On 04/11/2019 04:12 AM, Peter Zijlstra wrote: > > > On Wed, Apr 10, 2019 at 02:42:19PM -0400, Waiman Long wrote: > > >> The owner field in the rw_semaphore structure is used primarily for > > >> optimisti

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-12 Thread Ingo Molnar
* Waiman Long wrote: > On 04/11/2019 04:12 AM, Peter Zijlstra wrote: > > On Wed, Apr 10, 2019 at 02:42:19PM -0400, Waiman Long wrote: > >> The owner field in the rw_semaphore structure is used primarily for > >> optimistic spinning. However, identifying the rwsem owner can also be > >> helpful

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-11 Thread Waiman Long
On 04/11/2019 04:12 AM, Peter Zijlstra wrote: > On Wed, Apr 10, 2019 at 02:42:19PM -0400, Waiman Long wrote: >> The owner field in the rw_semaphore structure is used primarily for >> optimistic spinning. However, identifying the rwsem owner can also be >> helpful in debugging as well as tracing loc

Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-11 Thread Peter Zijlstra
On Wed, Apr 10, 2019 at 02:42:19PM -0400, Waiman Long wrote: > The owner field in the rw_semaphore structure is used primarily for > optimistic spinning. However, identifying the rwsem owner can also be > helpful in debugging as well as tracing locking related issues when > analyzing crash dump. Th

[PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON_OWNER

2019-04-10 Thread Waiman Long
The owner field in the rw_semaphore structure is used primarily for optimistic spinning. However, identifying the rwsem owner can also be helpful in debugging as well as tracing locking related issues when analyzing crash dump. The owner field may also store state information that can be important