Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tue, Sep 8, 2015 at 5:07 PM, Vaibhav Hiremath wrote: > But I still have one small doubt on expectation from > devm_pinctrl_get() function. > > If pinctrl properties are not populated in Devicetree node, > then, shouldn't devm_pinctrl_get() return error ? > I followed the code flow, and it

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tue, Sep 8, 2015 at 5:07 PM, Vaibhav Hiremath wrote: > But I still have one small doubt on expectation from > devm_pinctrl_get() function. > > If pinctrl properties are not populated in Devicetree node, > then, shouldn't devm_pinctrl_get() return error ? > I

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tuesday 08 September 2015 08:12 PM, Linus Walleij wrote: On Mon, Sep 7, 2015 at 1:18 PM, Vaibhav Hiremath wrote: Different bus clock may need different pin setting. For example, fast bus clock like 208Mhz need pin drive fast while slow bus clock prefer pin drive slow to guarantee signal

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Mon, Sep 7, 2015 at 1:18 PM, Vaibhav Hiremath wrote: > Different bus clock may need different pin setting. > For example, fast bus clock like 208Mhz need pin drive fast > while slow bus clock prefer pin drive slow to guarantee > signal quality. > > So this patch creates two states, > -

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tuesday 08 September 2015 03:34 PM, Jisheng Zhang wrote: On Tue, 8 Sep 2015 15:32:34 +0530 Vaibhav Hiremath wrote: On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote: On Tue, 8 Sep 2015 15:04:41 +0530 Vaibhav Hiremath wrote: static const struct sdhci_ops

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tue, 8 Sep 2015 15:32:34 +0530 Vaibhav Hiremath wrote: > > > On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote: > > On Tue, 8 Sep 2015 15:04:41 +0530 > > Vaibhav Hiremath wrote: > > > >> > >> > >> On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote: > >>> On Mon, 7 Sep 2015

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote: On Tue, 8 Sep 2015 15:04:41 +0530 Vaibhav Hiremath wrote: On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote: On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath wrote: Different bus clock may need different pin

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tue, 8 Sep 2015 15:04:41 +0530 Vaibhav Hiremath wrote: > > > On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote: > > On Mon, 7 Sep 2015 16:48:38 +0530 > > Vaibhav Hiremath wrote: > > > >> Different bus clock may need different pin setting. > >> For example, fast bus clock like

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tuesday 08 September 2015 12:24 PM, Jisheng Zhang wrote: On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath wrote: Different bus clock may need different pin setting. For example, fast bus clock like 208Mhz need pin drive fast while slow bus clock prefer pin drive slow to guarantee

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote: On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath wrote: Different bus clock may need different pin setting. For example, fast bus clock like 208Mhz need pin drive fast while slow bus clock prefer pin drive slow to guarantee

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath wrote: > Different bus clock may need different pin setting. > For example, fast bus clock like 208Mhz need pin drive fast > while slow bus clock prefer pin drive slow to guarantee > signal quality. > > So this patch creates two states, > -

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath wrote: > Different bus clock may need different pin setting. > For example, fast bus clock like 208Mhz need pin drive fast > while slow bus clock prefer pin drive slow to guarantee > signal quality. > > So this patch creates two states, > -

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath wrote: > Different bus clock may need different pin setting. > For example, fast bus clock like 208Mhz need pin drive fast > while slow bus clock prefer pin drive slow to guarantee > signal quality. > > So this

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote: On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath wrote: Different bus clock may need different pin setting. For example, fast bus clock like 208Mhz need pin drive fast while slow bus clock prefer pin

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath wrote: > Different bus clock may need different pin setting. > For example, fast bus clock like 208Mhz need pin drive fast > while slow bus clock prefer pin drive slow to guarantee > signal quality. > > So this

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote: On Tue, 8 Sep 2015 15:04:41 +0530 Vaibhav Hiremath wrote: On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote: On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tue, 8 Sep 2015 15:32:34 +0530 Vaibhav Hiremath wrote: > > > On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote: > > On Tue, 8 Sep 2015 15:04:41 +0530 > > Vaibhav Hiremath wrote: > > > >> > >> > >> On Tuesday 08 September

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tuesday 08 September 2015 03:34 PM, Jisheng Zhang wrote: On Tue, 8 Sep 2015 15:32:34 +0530 Vaibhav Hiremath wrote: On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote: On Tue, 8 Sep 2015 15:04:41 +0530 Vaibhav Hiremath

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tue, 8 Sep 2015 15:04:41 +0530 Vaibhav Hiremath wrote: > > > On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote: > > On Mon, 7 Sep 2015 16:48:38 +0530 > > Vaibhav Hiremath wrote: > > > >> Different bus clock may need

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tuesday 08 September 2015 12:24 PM, Jisheng Zhang wrote: On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath wrote: Different bus clock may need different pin setting. For example, fast bus clock like 208Mhz need pin drive fast while slow bus clock prefer pin

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Mon, Sep 7, 2015 at 1:18 PM, Vaibhav Hiremath wrote: > Different bus clock may need different pin setting. > For example, fast bus clock like 208Mhz need pin drive fast > while slow bus clock prefer pin drive slow to guarantee > signal quality. > > So this patch

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

On Tuesday 08 September 2015 08:12 PM, Linus Walleij wrote: On Mon, Sep 7, 2015 at 1:18 PM, Vaibhav Hiremath wrote: Different bus clock may need different pin setting. For example, fast bus clock like 208Mhz need pin drive fast while slow bus clock prefer pin

[PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

Different bus clock may need different pin setting. For example, fast bus clock like 208Mhz need pin drive fast while slow bus clock prefer pin drive slow to guarantee signal quality. So this patch creates two states, - Default (slow/normal) pin state - And fast pin state for higher freq bus

[PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

Different bus clock may need different pin setting. For example, fast bus clock like 208Mhz need pin drive fast while slow bus clock prefer pin drive slow to guarantee signal quality. So this patch creates two states, - Default (slow/normal) pin state - And fast pin state for higher freq bus