Re: [PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-10-25 Thread Wolfram Sang
> >>Enable i2c module/unit before transmission and disable when it > >>finishes. > > >Can't you use Runtime PM for that? > > > > I haven't tried it though, I can give a try and check. It should work. Other I2C drivers are doing exactly that. signature.asc Description: Digital signature

Re: [PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-10-25 Thread Wolfram Sang
> >>Enable i2c module/unit before transmission and disable when it > >>finishes. > > >Can't you use Runtime PM for that? > > > > I haven't tried it though, I can give a try and check. It should work. Other I2C drivers are doing exactly that. signature.asc Description: Digital signature

Re: [PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-09-13 Thread Vaibhav Hiremath
On Saturday 12 September 2015 12:23 AM, Wolfram Sang wrote: On Mon, Aug 24, 2015 at 11:29:35AM +0530, Vaibhav Hiremath wrote: From: Yi Zhang Enable i2c module/unit before transmission and disable when it finishes. why? It's because the i2c bus may be disturbed if the slave device,

Re: [PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-09-13 Thread Vaibhav Hiremath
On Saturday 12 September 2015 12:23 AM, Wolfram Sang wrote: On Mon, Aug 24, 2015 at 11:29:35AM +0530, Vaibhav Hiremath wrote: From: Yi Zhang Enable i2c module/unit before transmission and disable when it finishes. why? It's because the i2c bus may be disturbed if the

Re: [PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-09-11 Thread Wolfram Sang
On Mon, Aug 24, 2015 at 11:29:35AM +0530, Vaibhav Hiremath wrote: > From: Yi Zhang > > Enable i2c module/unit before transmission and disable when it > finishes. > > why? > It's because the i2c bus may be disturbed if the slave device, > typically a touch, powers on. I am not convinced, "may

Re: [PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-09-11 Thread Wolfram Sang
On Mon, Aug 24, 2015 at 11:29:35AM +0530, Vaibhav Hiremath wrote: > From: Yi Zhang > > Enable i2c module/unit before transmission and disable when it > finishes. > > why? > It's because the i2c bus may be disturbed if the slave device, > typically a touch, powers on. I am

[PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-08-24 Thread Vaibhav Hiremath
From: Yi Zhang Enable i2c module/unit before transmission and disable when it finishes. why? It's because the i2c bus may be disturbed if the slave device, typically a touch, powers on. As we do not want to break slave mode support, this patch introduces DT property to control disable of the

[PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-08-24 Thread Vaibhav Hiremath
From: Yi Zhang yizh...@marvell.com Enable i2c module/unit before transmission and disable when it finishes. why? It's because the i2c bus may be disturbed if the slave device, typically a touch, powers on. As we do not want to break slave mode support, this patch introduces DT property to