Re: [PATCH (resend)] mailbox: Add Altera mailbox driver

2014-12-17 Thread Ley Foon Tan
On Thu, Dec 18, 2014 at 1:17 AM, Dinh Nguyen wrote: > +MODULE_DEVICE_TABLE(of, altera_mbox_match); > + > +static struct platform_driver altera_mbox_driver = { > +.probe = altera_mbox_probe, > +.remove = altera_mbox_remove, > +.driver = { > +.nam

Re: [PATCH (resend)] mailbox: Add Altera mailbox driver

2014-12-17 Thread Dinh Nguyen
On 12/16/14, 12:33 AM, Ley Foon Tan wrote: > On Tue, Dec 16, 2014 at 4:54 AM, Suman Anna wrote: >> Hi Ley Foon, >> >> On 12/12/2014 08:38 AM, Dinh Nguyen wrote: >>> >>> >>> On 12/12/14, 4:04 AM, Ley Foon Tan wrote: The Altera mailbox allows for interprocessor communication. It supports

Re: [PATCH (resend)] mailbox: Add Altera mailbox driver

2014-12-16 Thread Ley Foon Tan
On Wed, Dec 17, 2014 at 3:53 AM, Suman Anna wrote: >>> I think this logic in general will conflict between interrupt and poll >>> mode. send_data is supposed to return -EBUSY only in polling mode and >>> not in interrupt mode. >> What is the recommended error code for this case? BTW, omap-mailbox

Re: [PATCH (resend)] mailbox: Add Altera mailbox driver

2014-12-16 Thread Suman Anna
Hi Ley Foon, On 12/16/2014 12:33 AM, Ley Foon Tan wrote: > On Tue, Dec 16, 2014 at 4:54 AM, Suman Anna wrote: >> Hi Ley Foon, >> >> On 12/12/2014 08:38 AM, Dinh Nguyen wrote: >>> >>> >>> On 12/12/14, 4:04 AM, Ley Foon Tan wrote: The Altera mailbox allows for interprocessor communication. It

Re: [PATCH (resend)] mailbox: Add Altera mailbox driver

2014-12-15 Thread Ley Foon Tan
On Tue, Dec 16, 2014 at 4:54 AM, Suman Anna wrote: > Hi Ley Foon, > > On 12/12/2014 08:38 AM, Dinh Nguyen wrote: >> >> >> On 12/12/14, 4:04 AM, Ley Foon Tan wrote: >>> The Altera mailbox allows for interprocessor communication. It supports >>> only one channel and work as either sender or receiver

Re: [PATCH (resend)] mailbox: Add Altera mailbox driver

2014-12-15 Thread Ley Foon Tan
On Mon, Dec 15, 2014 at 10:22 PM, Dinh Nguyen wrote: > > > On 12/15/14, 12:22 AM, Ley Foon Tan wrote: >> On Fri, Dec 12, 2014 at 10:38 PM, Dinh Nguyen wrote: >> + +#include +#include +#include +#include +#include +#include +#include +#include >

Re: [PATCH (resend)] mailbox: Add Altera mailbox driver

2014-12-15 Thread Suman Anna
Hi Ley Foon, On 12/12/2014 08:38 AM, Dinh Nguyen wrote: > > > On 12/12/14, 4:04 AM, Ley Foon Tan wrote: >> The Altera mailbox allows for interprocessor communication. It supports >> only one channel and work as either sender or receiver. I have a few more comments in addition to those that Dinh

Re: [PATCH (resend)] mailbox: Add Altera mailbox driver

2014-12-15 Thread Dinh Nguyen
On 12/15/14, 12:22 AM, Ley Foon Tan wrote: > On Fri, Dec 12, 2014 at 10:38 PM, Dinh Nguyen wrote: > >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >> >> Alphabetize the headers. > Okay. > > >>> +static int altera_m

Re: [PATCH (resend)] mailbox: Add Altera mailbox driver

2014-12-14 Thread Ley Foon Tan
On Fri, Dec 12, 2014 at 10:38 PM, Dinh Nguyen wrote: >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > Alphabetize the headers. Okay. >> +static int altera_mbox_startup_sender(struct mbox_chan *chan) >> +{ >> + int ret;

Re: [PATCH (resend)] mailbox: Add Altera mailbox driver

2014-12-12 Thread Dinh Nguyen
On 12/12/14, 4:04 AM, Ley Foon Tan wrote: > The Altera mailbox allows for interprocessor communication. It supports > only one channel and work as either sender or receiver. > > Signed-off-by: Ley Foon Tan > --- > .../devicetree/bindings/mailbox/altera-mailbox.txt | 49 +++ > drivers/mailbox/

[PATCH (resend)] mailbox: Add Altera mailbox driver

2014-12-12 Thread Ley Foon Tan
The Altera mailbox allows for interprocessor communication. It supports only one channel and work as either sender or receiver. Signed-off-by: Ley Foon Tan --- .../devicetree/bindings/mailbox/altera-mailbox.txt | 49 +++ drivers/mailbox/Kconfig| 6 + drivers/mailbo