Re: [PATCH (v2)] crypto: Remove pointless padlock module

2007-05-20 Thread Simon Arlott
On 20/05/07 04:15, Herbert Xu wrote: On Sat, May 19, 2007 at 08:28:17PM +0100, Simon Arlott wrote: It should be a bool that doesn't select anything, the AES and SHA modules will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7 instead of X86_32. Having it as a tristate means

Re: [PATCH (v2)] crypto: Remove pointless padlock module

2007-05-20 Thread Simon Arlott
On 20/05/07 04:15, Herbert Xu wrote: On Sat, May 19, 2007 at 08:28:17PM +0100, Simon Arlott wrote: It should be a bool that doesn't select anything, the AES and SHA modules will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7 instead of X86_32. Having it as a tristate means

Re: [PATCH (v2)] crypto: Remove pointless padlock module

2007-05-19 Thread Herbert Xu
On Sat, May 19, 2007 at 08:28:17PM +0100, Simon Arlott wrote: > > It should be a bool that doesn't select anything, the AES and SHA modules > will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7 > instead of X86_32. Having it as a tristate means that we don't have to

Re: [PATCH (v2)] crypto: Remove pointless padlock module

2007-05-19 Thread Dave Jones
On Sat, May 19, 2007 at 08:28:17PM +0100, Simon Arlott wrote: > > BTW, I noticed that this prevented CRYPTO_ALGAPI from being marked as m > > since it was selected by CRYPTO_DEV_PADLOCK. So I'm turning it into a > > tristate again. > > It should be a bool that doesn't select anything, the

Re: [PATCH (v2)] crypto: Remove pointless padlock module

2007-05-19 Thread Simon Arlott
On 18/05/07 07:45, Herbert Xu wrote: On Sun, Apr 29, 2007 at 09:01:10AM +0100, Simon Arlott wrote: When this is compiled in it is run too early to do anything useful: [6.052000] padlock: No VIA PadLock drivers have been loaded. [6.052000] padlock: Using VIA PadLock ACE for AES

Re: [PATCH (v2)] crypto: Remove pointless padlock module

2007-05-19 Thread Dave Jones
On Sat, May 19, 2007 at 08:28:17PM +0100, Simon Arlott wrote: BTW, I noticed that this prevented CRYPTO_ALGAPI from being marked as m since it was selected by CRYPTO_DEV_PADLOCK. So I'm turning it into a tristate again. It should be a bool that doesn't select anything, the AES and

Re: [PATCH (v2)] crypto: Remove pointless padlock module

2007-05-19 Thread Herbert Xu
On Sat, May 19, 2007 at 08:28:17PM +0100, Simon Arlott wrote: It should be a bool that doesn't select anything, the AES and SHA modules will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7 instead of X86_32. Having it as a tristate means that we don't have to duplicate

Re: [PATCH (v2)] crypto: Remove pointless padlock module

2007-05-18 Thread Herbert Xu
On Sun, Apr 29, 2007 at 09:01:10AM +0100, Simon Arlott wrote: > When this is compiled in it is run too early to do anything useful: > [6.052000] padlock: No VIA PadLock drivers have been loaded. > [6.052000] padlock: Using VIA PadLock ACE for AES algorithm. > [6.052000] padlock: Using

Re: [PATCH (v2)] crypto: Remove pointless padlock module

2007-05-18 Thread Herbert Xu
On Sun, Apr 29, 2007 at 09:01:10AM +0100, Simon Arlott wrote: When this is compiled in it is run too early to do anything useful: [6.052000] padlock: No VIA PadLock drivers have been loaded. [6.052000] padlock: Using VIA PadLock ACE for AES algorithm. [6.052000] padlock: Using VIA

Re: [PATCH (v2)] crypto: Remove pointless padlock module

2007-05-01 Thread Herbert Xu
On Sun, Apr 29, 2007 at 09:01:10AM +0100, Simon Arlott wrote: > > Well that's mostly the point - it shouldn't get compiled in - ever, > but it also has other modules depending on it in Kconfig that > shouldn't need to be modules. Patch applied. Thanks! -- Visit Openswan at

Re: [PATCH (v2)] crypto: Remove pointless padlock module

2007-05-01 Thread Herbert Xu
On Sun, Apr 29, 2007 at 09:01:10AM +0100, Simon Arlott wrote: Well that's mostly the point - it shouldn't get compiled in - ever, but it also has other modules depending on it in Kconfig that shouldn't need to be modules. Patch applied. Thanks! -- Visit Openswan at

[PATCH (v2)] crypto: Remove pointless padlock module

2007-04-29 Thread Simon Arlott
When this is compiled in it is run too early to do anything useful: [6.052000] padlock: No VIA PadLock drivers have been loaded. [6.052000] padlock: Using VIA PadLock ACE for AES algorithm. [6.052000] padlock: Using VIA PadLock ACE for SHA1/SHA256 algorithms. When it's a module it

[PATCH (v2)] crypto: Remove pointless padlock module

2007-04-29 Thread Simon Arlott
When this is compiled in it is run too early to do anything useful: [6.052000] padlock: No VIA PadLock drivers have been loaded. [6.052000] padlock: Using VIA PadLock ACE for AES algorithm. [6.052000] padlock: Using VIA PadLock ACE for SHA1/SHA256 algorithms. When it's a module it