Re: [PATCH -mm] 64bit-futex - provide new commands instead of new syscall

2007-04-23 Thread Ulrich Drepper
On 4/23/07, Pierre Peiffer <[EMAIL PROTECTED]> wrote: Following this mail sent few weeks ago, here is a patch which should meet your requirements. [...] It looks mostly good. I wouldn't use the high bit to differentiate the 64-bit operations, though. Since we do not allow to apply it to all

[PATCH -mm] 64bit-futex - provide new commands instead of new syscall

2007-04-23 Thread Pierre Peiffer
Hi, Jakub Jelinek a écrit : I don't think you should blindly add all operations to sys_futex64 without thinking what they really do. E.g. FUTEX_{{,UN,TRY}LOCK,CMP_REQUEUE}_PI doesn't really make any sense for 64-bit futexes, the format of PI futexes is hardcoded in the kernel and is always

[PATCH -mm] 64bit-futex - provide new commands instead of new syscall

2007-04-23 Thread Pierre Peiffer
Hi, Jakub Jelinek a écrit : I don't think you should blindly add all operations to sys_futex64 without thinking what they really do. E.g. FUTEX_{{,UN,TRY}LOCK,CMP_REQUEUE}_PI doesn't really make any sense for 64-bit futexes, the format of PI futexes is hardcoded in the kernel and is always

Re: [PATCH -mm] 64bit-futex - provide new commands instead of new syscall

2007-04-23 Thread Ulrich Drepper
On 4/23/07, Pierre Peiffer [EMAIL PROTECTED] wrote: Following this mail sent few weeks ago, here is a patch which should meet your requirements. [...] It looks mostly good. I wouldn't use the high bit to differentiate the 64-bit operations, though. Since we do not allow to apply it to all