On Fri, 9 Mar 2007 12:04:59 +0800, Sonic Zhang wrote:
> On 3/8/07, Jean Delvare <[EMAIL PROTECTED]> wrote:
> > i2c-core can emulate SMBus transactions using master_xfer, so in
> > general when you have a complete master_xfer implementation you do not
> > need to define a separate smbus_xfer functio
On 3/8/07, Jean Delvare <[EMAIL PROTECTED]> wrote:
Hi Brian,
Thanks for the quick update.
> +
> + rc = (iface->result >= 0) ? 0 : -1;
> +
> + /* Release mutex */
> + mutex_unlock(&iface->twi_lock);
> +
> + return rc;
> +}
i2c-core can emulate SMBus transactions using master
Hi Brian,
Thanks for the quick update.
> [PATCH] Blackfin: blackfin i2c driver
>
> The i2c linux driver for blackfin architecture which supports both GPIO
> i2c operation and blackfin on-chip TWI controller i2c operation.
>
> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]>
> Reviewed-by: Andrew Mor
On Tue, 6 Mar 2007 23:45:29 -0800, Andrew Morton wrote:
> On Wed, 07 Mar 2007 15:39:27 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
>
> > Thanks a lot, could you please give me a script just to kill this
> > whitespace? So I can do it before sending you patches.
>
>
> Is pretty simple:
>
> #!/b
> From: Andrew Morton
> Newsgroups: gmane.linux.kernel
> Subject: Re: [PATCH -mm] Blackfin: blackfin i2c driver
> Date: Tue, 6 Mar 2007 23:45:29 -0800
[]
> On Wed, 07 Mar 2007 15:39:27 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
>
>> Thanks a lot, could
> > Signed-off-by: Bryan Wu <[EMAIL PROTECTED]>
> > ---
> > drivers/i2c/busses/Kconfig | 47
> > drivers/i2c/busses/i2c-bfin-gpio.c | 98 +
> > drivers/i2c/busses/i2c-bfin-twi.c | 589
> >
>
> I'd prefer i2c-bla
On Wed, 07 Mar 2007 15:39:27 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
> Thanks a lot, could you please give me a script just to kill this
> whitespace? So I can do it before sending you patches.
Is pretty simple:
#!/bin/sh
#
# Strip any trailing whitespace which a unified diff adds.
#
stri
On Tue, 2007-03-06 at 23:14 -0800, Andrew Morton wrote:
> On Wed, 7 Mar 2007 07:58:22 +0100 Jean Delvare <[EMAIL PROTECTED]> wrote:
>
> > > +config BFIN_SDA
> >
> > I2C_BLACKFIN_SDA
>
> The blackfin architecture uses "bfin" pretty much universally, so this
> usage is consistent.
>
> box:/usr/sr
On Wed, 7 Mar 2007 07:58:22 +0100 Jean Delvare <[EMAIL PROTECTED]> wrote:
> > +config BFIN_SDA
>
> I2C_BLACKFIN_SDA
The blackfin architecture uses "bfin" pretty much universally, so this
usage is consistent.
box:/usr/src/25> grep -i blackfin patches/blackfin*|wc -l
1608
box:/usr/src/25> grep
On Wed, 07 Mar 2007 13:57:58 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
> Here is the updated blackfin i2c driver.
>
> [PATCH] Blackfin: blackfin i2c driver
>
> The i2c linux driver for blackfin architecture which supports both GPIO
> i2c operation and blackfin on-chip TWI controller i2c opera
Hi Bryan,
On Wed, 07 Mar 2007 13:57:58 +0800, Wu, Bryan wrote:
> Here is the updated blackfin i2c driver.
>
> [PATCH] Blackfin: blackfin i2c driver
>
> The i2c linux driver for blackfin architecture which supports both GPIO
> i2c operation and blackfin on-chip TWI controller i2c operation.
>
>
> >
> > OK, I change it into yield(). So, current process will be move to the
> > tail of the run queue. Is that OK with you?
>
> Nope, yield is terribly bad when there are busy processes running: it can
> stall for a very long time indeed,
>
> Is this hardware not capable of generating an inter
On Wed, 7 Mar 2007 13:17:57 +0800 "Sonic Zhang" <[EMAIL PROTECTED]> wrote:
> On 3/6/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> > On Tue, 06 Mar 2007 14:54:18 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
> >
> > > Hi folks,
> > >
> > > [PATCH] Blackfin: blackfin i2c driver
> > >
>
> > > +
Dear Andrew and Alexey:
Thanks a lot for the review.
Here is the updated blackfin i2c driver.
[PATCH] Blackfin: blackfin i2c driver
The i2c linux driver for blackfin architecture which supports both GPIO
i2c operation and blackfin on-chip TWI controller i2c operation.
Signed-off-by: Bryan Wu <
On 3/6/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
On Tue, 06 Mar 2007 14:54:18 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
> Hi folks,
>
> [PATCH] Blackfin: blackfin i2c driver
>
> + struct i2c_msg *pmsg;
> + int i, ret;
> + int rc = 0;
> +
> + if (!(bfin_read_TWI_CONTROL()
On 3/6/07, Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
> +static int __init i2c_bfin_twi_init(void)
> +{
> + rc = request_irq(twi_iface.irq, bfin_twi_interrupt_entry, SA_INTERRUPT,
"i2c-bfin-twi", &twi_iface);
> + if (rc) {
> + printk(KERN_ERR "i2c-bfin-twi: can't get IRQ %d !
On Tue, Mar 06, 2007 at 02:54:18PM +0800, Wu, Bryan wrote:
> [PATCH] Blackfin: blackfin i2c driver
>
> The i2c linux driver for blackfin architecture which supports both GPIO
> i2c operation and blackfin on-chip TWI controller i2c operation.
> +config TWICLK_KHZ
> + int "TWI clock (kHZ)"
> +
On Tue, 06 Mar 2007 14:54:18 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote:
> Hi folks,
>
> [PATCH] Blackfin: blackfin i2c driver
>
> The i2c linux driver for blackfin architecture which supports both GPIO
> i2c operation and blackfin on-chip TWI controller i2c operation.
>
Little things...
>
Hi folks,
[PATCH] Blackfin: blackfin i2c driver
The i2c linux driver for blackfin architecture which supports both GPIO
i2c operation and blackfin on-chip TWI controller i2c operation.
Signed-off-by: Bryan Wu <[EMAIL PROTECTED]>
---
drivers/i2c/busses/Kconfig | 47
drivers/i2c/
19 matches
Mail list logo
