Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
On Mon, 3 Sep 2007, Satyam Sharma wrote: > > On Sun, 2 Sep 2007, Alistair John Strachan wrote: > > > > The encoding is set to ISO-2022-JP, this is probably breaking things. > > ??? I have no clue how/why/when that suddenly happened. > > I clearly see "Content-Type: TEXT/PLAIN;

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Alistair John Strachan wrote: > On Sunday 02 September 2007 21:23:16 Jesper Juhl wrote: > > On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > > Hi Jesper, > > > > > > On Sun, 2 Sep 2007, Jesper Juhl wrote: > > > > > - if (!(interface =

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Alistair John Strachan
On Sunday 02 September 2007 21:23:16 Jesper Juhl wrote: > On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > Hi Jesper, > > > > On Sun, 2 Sep 2007, Jesper Juhl wrote: > > > > - if (!(interface = usb_find_interface(_driver, > > > > subminor))) { -

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Jesper Juhl
On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > Hi Jesper, > > > On Sun, 2 Sep 2007, Jesper Juhl wrote: > > > > > - if (!(interface = usb_find_interface(_driver, subminor))) { > > > - dev_err(>sisusb_dev->dev, "Failed to find > > > interface¥n"); > > > > Odd how in

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
Hi Jesper, On Sun, 2 Sep 2007, Jesper Juhl wrote: > > > - if (!(interface = usb_find_interface(_driver, subminor))) { > > - dev_err(>sisusb_dev->dev, "Failed to find > > interface¥n"); > > Odd how in your patch the line ends with "¥n" but if I look in my > local copy of

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Jesper Juhl
On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > drivers/usb/misc/sisusbvga/sisusb.c: In function 'usb_sisusb_init': > drivers/usb/misc/sisusbvga/sisusb.c:3321: warning: unused variable 'sisusb' > drivers/usb/misc/sisusbvga/sisusb.c:3320: warning: unused variable 'retval' > > are

[PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
drivers/usb/misc/sisusbvga/sisusb.c: In function ‘usb_sisusb_init’: drivers/usb/misc/sisusbvga/sisusb.c:3321: warning: unused variable ‘sisusb’ drivers/usb/misc/sisusbvga/sisusb.c:3320: warning: unused variable ‘retval’ are trivially solved by getting rid of the unused variables.

[PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
drivers/usb/misc/sisusbvga/sisusb.c: In function ‘usb_sisusb_init’: drivers/usb/misc/sisusbvga/sisusb.c:3321: warning: unused variable ‘sisusb’ drivers/usb/misc/sisusbvga/sisusb.c:3320: warning: unused variable ‘retval’ are trivially solved by getting rid of the unused variables.

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Jesper Juhl
On 02/09/07, Satyam Sharma [EMAIL PROTECTED] wrote: drivers/usb/misc/sisusbvga/sisusb.c: In function 'usb_sisusb_init': drivers/usb/misc/sisusbvga/sisusb.c:3321: warning: unused variable 'sisusb' drivers/usb/misc/sisusbvga/sisusb.c:3320: warning: unused variable 'retval' are trivially solved

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
Hi Jesper, On Sun, 2 Sep 2007, Jesper Juhl wrote: - if (!(interface = usb_find_interface(sisusb_driver, subminor))) { - dev_err(sisusb-sisusb_dev-dev, Failed to find interface¥n); Odd how in your patch the line ends with ¥n but if I look in my local copy of the

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Jesper Juhl
On 02/09/07, Satyam Sharma [EMAIL PROTECTED] wrote: Hi Jesper, On Sun, 2 Sep 2007, Jesper Juhl wrote: - if (!(interface = usb_find_interface(sisusb_driver, subminor))) { - dev_err(sisusb-sisusb_dev-dev, Failed to find interface¥n); Odd how in your patch the

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Alistair John Strachan
On Sunday 02 September 2007 21:23:16 Jesper Juhl wrote: On 02/09/07, Satyam Sharma [EMAIL PROTECTED] wrote: Hi Jesper, On Sun, 2 Sep 2007, Jesper Juhl wrote: - if (!(interface = usb_find_interface(sisusb_driver, subminor))) { - dev_err(sisusb-sisusb_dev-dev,

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Alistair John Strachan wrote: On Sunday 02 September 2007 21:23:16 Jesper Juhl wrote: On 02/09/07, Satyam Sharma [EMAIL PROTECTED] wrote: Hi Jesper, On Sun, 2 Sep 2007, Jesper Juhl wrote: - if (!(interface = usb_find_interface(sisusb_driver,

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
On Mon, 3 Sep 2007, Satyam Sharma wrote: On Sun, 2 Sep 2007, Alistair John Strachan wrote: The encoding is set to ISO-2022-JP, this is probably breaking things. ??? I have no clue how/why/when that suddenly happened. I clearly see Content-Type: TEXT/PLAIN; charset=us-ascii for the