Re: [PATCH -mm] vmscan: fix sane_reclaim helper for legacy memcg

2015-09-18 Thread Tejun Heo
Hello, On Fri, Sep 18, 2015 at 03:48:00PM +0300, Vladimir Davydov wrote: > The sane_reclaim() helper is supposed to return false for memcg reclaim > if the legacy hierarchy is used, because the latter lacks dirty > throttling mechanism, and so it did before it was accidentally broken by > commit 3

Re: [PATCH -mm] vmscan: fix sane_reclaim helper for legacy memcg

2015-09-18 Thread Michal Hocko
On Fri 18-09-15 15:48:00, Vladimir Davydov wrote: > The sane_reclaim() helper is supposed to return false for memcg reclaim > if the legacy hierarchy is used, because the latter lacks dirty > throttling mechanism, and so it did before it was accidentally broken by > commit 33398cf2f360c ("memcg: ex

Re: [PATCH -mm] vmscan: fix sane_reclaim helper for legacy memcg

2015-09-18 Thread Tejun Heo
On Fri, Sep 18, 2015 at 03:48:00PM +0300, Vladimir Davydov wrote: > The sane_reclaim() helper is supposed to return false for memcg reclaim > if the legacy hierarchy is used, because the latter lacks dirty > throttling mechanism, and so it did before it was accidentally broken by > commit 33398cf2f

[PATCH -mm] vmscan: fix sane_reclaim helper for legacy memcg

2015-09-18 Thread Vladimir Davydov
The sane_reclaim() helper is supposed to return false for memcg reclaim if the legacy hierarchy is used, because the latter lacks dirty throttling mechanism, and so it did before it was accidentally broken by commit 33398cf2f360c ("memcg: export struct mem_cgroup"). Fix it. Fixes: 33398cf2f360c ("