Re: [PATCH -mm] workqueue: debug possible lockups in flush_workqueue

2007-04-19 Thread Jarek Poplawski
On Thu, Apr 19, 2007 at 08:14:16AM +0200, Ingo Molnar wrote: > > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > Here is my patch proposal for detecting possible lockups, when > > flush_workqueue caller holds a lock (e.g. rtnl_lock) also used in work > > functions. > > looks good in

Re: [PATCH -mm] workqueue: debug possible lockups in flush_workqueue

2007-04-19 Thread Ingo Molnar
* Jarek Poplawski <[EMAIL PROTECTED]> wrote: > Here is my patch proposal for detecting possible lockups, when > flush_workqueue caller holds a lock (e.g. rtnl_lock) also used in work > functions. looks good in principle - did you test it and it caught a bug that wasnt caught before? >

Re: [PATCH -mm] workqueue: debug possible lockups in flush_workqueue

2007-04-19 Thread Ingo Molnar
* Jarek Poplawski [EMAIL PROTECTED] wrote: Here is my patch proposal for detecting possible lockups, when flush_workqueue caller holds a lock (e.g. rtnl_lock) also used in work functions. looks good in principle - did you test it and it caught a bug that wasnt caught before? +#ifdef

Re: [PATCH -mm] workqueue: debug possible lockups in flush_workqueue

2007-04-19 Thread Jarek Poplawski
On Thu, Apr 19, 2007 at 08:14:16AM +0200, Ingo Molnar wrote: * Jarek Poplawski [EMAIL PROTECTED] wrote: Here is my patch proposal for detecting possible lockups, when flush_workqueue caller holds a lock (e.g. rtnl_lock) also used in work functions. looks good in principle - did you

[PATCH -mm] workqueue: debug possible lockups in flush_workqueue

2007-04-18 Thread Jarek Poplawski
Hi, Here is my patch proposal for detecting possible lockups, when flush_workqueue caller holds a lock (e.g. rtnl_lock) also used in work functions. Regards, Jarek P. Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]> --- diff -Nurp 2.6.21-rc6-mm1-/kernel/workqueue.c

[PATCH -mm] workqueue: debug possible lockups in flush_workqueue

2007-04-18 Thread Jarek Poplawski
Hi, Here is my patch proposal for detecting possible lockups, when flush_workqueue caller holds a lock (e.g. rtnl_lock) also used in work functions. Regards, Jarek P. Signed-off-by: Jarek Poplawski [EMAIL PROTECTED] --- diff -Nurp 2.6.21-rc6-mm1-/kernel/workqueue.c