Re: [PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-31 Thread Michal Hocko
On Tue 31-10-17 16:37:10, Minchan Kim wrote: > On Tue, Oct 31, 2017 at 08:31:07AM +0100, Michal Hocko wrote: > > On Tue 31-10-17 11:17:02, Minchan Kim wrote: > > > On Mon, Oct 30, 2017 at 09:02:30AM +0100, Michal Hocko wrote: > > > > On Mon 30-10-17 08:57:13, Minchan Kim wrote: > > > > [...] > > >

Re: [PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-31 Thread Minchan Kim
On Tue, Oct 31, 2017 at 08:31:07AM +0100, Michal Hocko wrote: > On Tue 31-10-17 11:17:02, Minchan Kim wrote: > > On Mon, Oct 30, 2017 at 09:02:30AM +0100, Michal Hocko wrote: > > > On Mon 30-10-17 08:57:13, Minchan Kim wrote: > > > [...] > > > > Although it's better than old, we can make it simple,

Re: [PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-31 Thread Michal Hocko
On Tue 31-10-17 11:17:02, Minchan Kim wrote: > On Mon, Oct 30, 2017 at 09:02:30AM +0100, Michal Hocko wrote: > > On Mon 30-10-17 08:57:13, Minchan Kim wrote: > > [...] > > > Although it's better than old, we can make it simple, still. > > > > > > diff --git a/include/linux/swapops.h b/include/linu

Re: [PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-30 Thread Huang, Ying
Minchan Kim writes: > Hi Huang, > > On Tue, Oct 31, 2017 at 01:32:32PM +0800, Huang, Ying wrote: >> Hi, Minchan, >> >> Minchan Kim writes: >> >> > Hi Huang, >> > >> > On Fri, Oct 27, 2017 at 01:53:27PM +0800, Huang, Ying wrote: >> >> From: Huang Ying >> >> >> >> When a page fault occurs for

Re: [PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-30 Thread Minchan Kim
Hi Huang, On Tue, Oct 31, 2017 at 01:32:32PM +0800, Huang, Ying wrote: > Hi, Minchan, > > Minchan Kim writes: > > > Hi Huang, > > > > On Fri, Oct 27, 2017 at 01:53:27PM +0800, Huang, Ying wrote: > >> From: Huang Ying > >> > >> When a page fault occurs for a swap entry, the physical swap reada

Re: [PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-30 Thread Huang, Ying
Hi, Minchan, Minchan Kim writes: > Hi Huang, > > On Fri, Oct 27, 2017 at 01:53:27PM +0800, Huang, Ying wrote: >> From: Huang Ying >> >> When a page fault occurs for a swap entry, the physical swap readahead >> (not the VMA base swap readahead) may readahead several swap entries >> after the fa

Re: [PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-30 Thread Minchan Kim
On Mon, Oct 30, 2017 at 09:02:30AM +0100, Michal Hocko wrote: > On Mon 30-10-17 08:57:13, Minchan Kim wrote: > [...] > > Although it's better than old, we can make it simple, still. > > > > diff --git a/include/linux/swapops.h b/include/linux/swapops.h > > index 291c4b534658..f50d5a48f03a 100644 >

Re: [PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-30 Thread Michal Hocko
On Mon 30-10-17 08:57:13, Minchan Kim wrote: [...] > Although it's better than old, we can make it simple, still. > > diff --git a/include/linux/swapops.h b/include/linux/swapops.h > index 291c4b534658..f50d5a48f03a 100644 > --- a/include/linux/swapops.h > +++ b/include/linux/swapops.h > @@ -41,6

Re: [PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-29 Thread Minchan Kim
Hi Huang, On Fri, Oct 27, 2017 at 01:53:27PM +0800, Huang, Ying wrote: > From: Huang Ying > > When a page fault occurs for a swap entry, the physical swap readahead > (not the VMA base swap readahead) may readahead several swap entries > after the fault swap entry. The readahead algorithm calcu

Re: [PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-27 Thread Michal Hocko
On Fri 27-10-17 13:53:27, Huang, Ying wrote: > From: Huang Ying > > When a page fault occurs for a swap entry, the physical swap readahead > (not the VMA base swap readahead) may readahead several swap entries > after the fault swap entry. The readahead algorithm calculates some > of the swap en

[PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-26 Thread Huang, Ying
From: Huang Ying When a page fault occurs for a swap entry, the physical swap readahead (not the VMA base swap readahead) may readahead several swap entries after the fault swap entry. The readahead algorithm calculates some of the swap entries to readahead via increasing the offset of the fault