Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-05-02 Thread Huang, Ying
Minchan Kim writes: > Hi Huang, > > On Tue, May 02, 2017 at 01:35:24PM +0800, Huang, Ying wrote: >> Hi, Minchan, >> >> Minchan Kim writes: >> >> > On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote: >> >> In fact, during the test, I found the

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-05-02 Thread Huang, Ying
Minchan Kim writes: > Hi Huang, > > On Tue, May 02, 2017 at 01:35:24PM +0800, Huang, Ying wrote: >> Hi, Minchan, >> >> Minchan Kim writes: >> >> > On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote: >> >> In fact, during the test, I found the overhead of sort() is comparable >> >>

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-05-01 Thread Minchan Kim
Hi Huang, On Tue, May 02, 2017 at 01:35:24PM +0800, Huang, Ying wrote: > Hi, Minchan, > > Minchan Kim writes: > > > On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote: > >> In fact, during the test, I found the overhead of sort() is comparable > >> with the

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-05-01 Thread Minchan Kim
Hi Huang, On Tue, May 02, 2017 at 01:35:24PM +0800, Huang, Ying wrote: > Hi, Minchan, > > Minchan Kim writes: > > > On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote: > >> In fact, during the test, I found the overhead of sort() is comparable > >> with the performance difference of

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-05-01 Thread Huang, Ying
Hi, Minchan, Minchan Kim writes: > On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote: >> In fact, during the test, I found the overhead of sort() is comparable >> with the performance difference of adding likely()/unlikely() to the >> "if" in the function. > >

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-05-01 Thread Huang, Ying
Hi, Minchan, Minchan Kim writes: > On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote: >> In fact, during the test, I found the overhead of sort() is comparable >> with the performance difference of adding likely()/unlikely() to the >> "if" in the function. > > Huang, > > This

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-05-01 Thread Minchan Kim
On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote: > In fact, during the test, I found the overhead of sort() is comparable > with the performance difference of adding likely()/unlikely() to the > "if" in the function. Huang, This discussion is started from your optimization code:

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-05-01 Thread Minchan Kim
On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote: > In fact, during the test, I found the overhead of sort() is comparable > with the performance difference of adding likely()/unlikely() to the > "if" in the function. Huang, This discussion is started from your optimization code:

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-28 Thread Huang, Ying
"Huang, Ying" writes: > Minchan Kim writes: > >> On Fri, Apr 28, 2017 at 04:05:26PM +0800, Huang, Ying wrote: >>> Minchan Kim writes: >>> >>> > On Fri, Apr 28, 2017 at 09:09:53AM +0800, Huang, Ying wrote: >>> >> Minchan Kim

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-28 Thread Huang, Ying
"Huang, Ying" writes: > Minchan Kim writes: > >> On Fri, Apr 28, 2017 at 04:05:26PM +0800, Huang, Ying wrote: >>> Minchan Kim writes: >>> >>> > On Fri, Apr 28, 2017 at 09:09:53AM +0800, Huang, Ying wrote: >>> >> Minchan Kim writes: >>> >> >>> >> > On Wed, Apr 26, 2017 at 08:42:10PM +0800,

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-28 Thread Huang, Ying
Minchan Kim writes: > On Fri, Apr 28, 2017 at 04:05:26PM +0800, Huang, Ying wrote: >> Minchan Kim writes: >> >> > On Fri, Apr 28, 2017 at 09:09:53AM +0800, Huang, Ying wrote: >> >> Minchan Kim writes: >> >> >> >> > On Wed, Apr 26,

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-28 Thread Huang, Ying
Minchan Kim writes: > On Fri, Apr 28, 2017 at 04:05:26PM +0800, Huang, Ying wrote: >> Minchan Kim writes: >> >> > On Fri, Apr 28, 2017 at 09:09:53AM +0800, Huang, Ying wrote: >> >> Minchan Kim writes: >> >> >> >> > On Wed, Apr 26, 2017 at 08:42:10PM +0800, Huang, Ying wrote: >> >> >> Minchan

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-28 Thread Minchan Kim
On Fri, Apr 28, 2017 at 04:05:26PM +0800, Huang, Ying wrote: > Minchan Kim writes: > > > On Fri, Apr 28, 2017 at 09:09:53AM +0800, Huang, Ying wrote: > >> Minchan Kim writes: > >> > >> > On Wed, Apr 26, 2017 at 08:42:10PM +0800, Huang, Ying wrote: > >>

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-28 Thread Minchan Kim
On Fri, Apr 28, 2017 at 04:05:26PM +0800, Huang, Ying wrote: > Minchan Kim writes: > > > On Fri, Apr 28, 2017 at 09:09:53AM +0800, Huang, Ying wrote: > >> Minchan Kim writes: > >> > >> > On Wed, Apr 26, 2017 at 08:42:10PM +0800, Huang, Ying wrote: > >> >> Minchan Kim writes: > >> >> > >> >>

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-28 Thread Huang, Ying
Minchan Kim writes: > On Fri, Apr 28, 2017 at 09:09:53AM +0800, Huang, Ying wrote: >> Minchan Kim writes: >> >> > On Wed, Apr 26, 2017 at 08:42:10PM +0800, Huang, Ying wrote: >> >> Minchan Kim writes: >> >> >> >> > On Fri, Apr 21,

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-28 Thread Huang, Ying
Minchan Kim writes: > On Fri, Apr 28, 2017 at 09:09:53AM +0800, Huang, Ying wrote: >> Minchan Kim writes: >> >> > On Wed, Apr 26, 2017 at 08:42:10PM +0800, Huang, Ying wrote: >> >> Minchan Kim writes: >> >> >> >> > On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: >> >> >> "Huang,

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-28 Thread Minchan Kim
On Fri, Apr 28, 2017 at 09:09:53AM +0800, Huang, Ying wrote: > Minchan Kim writes: > > > On Wed, Apr 26, 2017 at 08:42:10PM +0800, Huang, Ying wrote: > >> Minchan Kim writes: > >> > >> > On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: > >>

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-28 Thread Minchan Kim
On Fri, Apr 28, 2017 at 09:09:53AM +0800, Huang, Ying wrote: > Minchan Kim writes: > > > On Wed, Apr 26, 2017 at 08:42:10PM +0800, Huang, Ying wrote: > >> Minchan Kim writes: > >> > >> > On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: > >> >> "Huang, Ying" writes: > >> >> > >>

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-27 Thread Huang, Ying
Minchan Kim writes: > On Wed, Apr 26, 2017 at 08:42:10PM +0800, Huang, Ying wrote: >> Minchan Kim writes: >> >> > On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: >> >> "Huang, Ying" writes: >> >> >> >> > Minchan Kim

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-27 Thread Huang, Ying
Minchan Kim writes: > On Wed, Apr 26, 2017 at 08:42:10PM +0800, Huang, Ying wrote: >> Minchan Kim writes: >> >> > On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: >> >> "Huang, Ying" writes: >> >> >> >> > Minchan Kim writes: >> >> > >> >> >> On Wed, Apr 19, 2017 at 04:14:43PM

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-27 Thread Tim Chen
On Thu, 2017-04-27 at 09:21 +0800, Huang, Ying wrote: > Tim Chen writes: > > > > > > > > > > > > From 7bd903c42749c448ef6acbbdee8dcbc1c5b498b9 Mon Sep 17 00:00:00 2001 > > > From: Huang Ying > > > Date: Thu, 23 Feb 2017 13:05:20 +0800 > > >

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-27 Thread Tim Chen
On Thu, 2017-04-27 at 09:21 +0800, Huang, Ying wrote: > Tim Chen writes: > > > > > > > > > > > > From 7bd903c42749c448ef6acbbdee8dcbc1c5b498b9 Mon Sep 17 00:00:00 2001 > > > From: Huang Ying > > > Date: Thu, 23 Feb 2017 13:05:20 +0800 > > > Subject: [PATCH -v5] mm, swap: Sort swap entries

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-26 Thread Minchan Kim
On Wed, Apr 26, 2017 at 08:42:10PM +0800, Huang, Ying wrote: > Minchan Kim writes: > > > On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: > >> "Huang, Ying" writes: > >> > >> > Minchan Kim writes: > >> > > >> >> On Wed,

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-26 Thread Minchan Kim
On Wed, Apr 26, 2017 at 08:42:10PM +0800, Huang, Ying wrote: > Minchan Kim writes: > > > On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: > >> "Huang, Ying" writes: > >> > >> > Minchan Kim writes: > >> > > >> >> On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: > >> >>>

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-26 Thread Huang, Ying
Tim Chen writes: >> >> From 7bd903c42749c448ef6acbbdee8dcbc1c5b498b9 Mon Sep 17 00:00:00 2001 >> From: Huang Ying >> Date: Thu, 23 Feb 2017 13:05:20 +0800 >> Subject: [PATCH -v5] mm, swap: Sort swap entries before free >> >>  >> --- >>  

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-26 Thread Huang, Ying
Tim Chen writes: >> >> From 7bd903c42749c448ef6acbbdee8dcbc1c5b498b9 Mon Sep 17 00:00:00 2001 >> From: Huang Ying >> Date: Thu, 23 Feb 2017 13:05:20 +0800 >> Subject: [PATCH -v5] mm, swap: Sort swap entries before free >> >>  >> --- >>  mm/swapfile.c | 43

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-26 Thread Tim Chen
> > From 7bd903c42749c448ef6acbbdee8dcbc1c5b498b9 Mon Sep 17 00:00:00 2001 > From: Huang Ying > Date: Thu, 23 Feb 2017 13:05:20 +0800 > Subject: [PATCH -v5] mm, swap: Sort swap entries before free > >  > --- >  mm/swapfile.c | 43

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-26 Thread Tim Chen
> > From 7bd903c42749c448ef6acbbdee8dcbc1c5b498b9 Mon Sep 17 00:00:00 2001 > From: Huang Ying > Date: Thu, 23 Feb 2017 13:05:20 +0800 > Subject: [PATCH -v5] mm, swap: Sort swap entries before free > >  > --- >  mm/swapfile.c | 43 ++- >  1 file changed,

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-26 Thread Huang, Ying
Minchan Kim writes: > On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: >> "Huang, Ying" writes: >> >> > Minchan Kim writes: >> > >> >> On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: >> >>> Minchan Kim

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-26 Thread Huang, Ying
Minchan Kim writes: > On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: >> "Huang, Ying" writes: >> >> > Minchan Kim writes: >> > >> >> On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: >> >>> Minchan Kim writes: >> >>> >> >>> > Hi Huang, >> >>> > >> >>> > On Fri, Apr

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-24 Thread Tim Chen
On Sun, 2017-04-23 at 21:16 +0800, Huang, Ying wrote: > Tim Chen writes: > > > > > On Fri, 2017-04-21 at 20:29 +0800, Huang, Ying wrote: > > > > > > "Huang, Ying" writes: > > > > > > > > > > > > > > > Minchan Kim

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-24 Thread Tim Chen
On Sun, 2017-04-23 at 21:16 +0800, Huang, Ying wrote: > Tim Chen writes: > > > > > On Fri, 2017-04-21 at 20:29 +0800, Huang, Ying wrote: > > > > > > "Huang, Ying" writes: > > > > > > > > > > > > > > > Minchan Kim writes: > > > > > > > > > > > > > > > > > > > On Wed, Apr 19, 2017 at

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-24 Thread Huang, Ying
Minchan Kim writes: > On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: >> "Huang, Ying" writes: >> >> > Minchan Kim writes: >> > >> >> On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: >> >>> Minchan Kim

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-24 Thread Huang, Ying
Minchan Kim writes: > On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: >> "Huang, Ying" writes: >> >> > Minchan Kim writes: >> > >> >> On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: >> >>> Minchan Kim writes: >> >>> >> >>> > Hi Huang, >> >>> > >> >>> > On Fri, Apr

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-23 Thread Minchan Kim
On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: > "Huang, Ying" writes: > > > Minchan Kim writes: > > > >> On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: > >>> Minchan Kim writes: > >>> > >>> > Hi Huang,

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-23 Thread Minchan Kim
On Fri, Apr 21, 2017 at 08:29:30PM +0800, Huang, Ying wrote: > "Huang, Ying" writes: > > > Minchan Kim writes: > > > >> On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: > >>> Minchan Kim writes: > >>> > >>> > Hi Huang, > >>> > > >>> > On Fri, Apr 07, 2017 at 02:49:01PM +0800,

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-23 Thread Huang, Ying
Tim Chen writes: > On Fri, 2017-04-21 at 20:29 +0800, Huang, Ying wrote: >> "Huang, Ying" writes: >> >> > >> > Minchan Kim writes: >> > >> > > >> > > On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: >> > > >

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-23 Thread Huang, Ying
Tim Chen writes: > On Fri, 2017-04-21 at 20:29 +0800, Huang, Ying wrote: >> "Huang, Ying" writes: >> >> > >> > Minchan Kim writes: >> > >> > > >> > > On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: >> > > > >> > > > Minchan Kim writes: >> > > > >> > > > > >> > > > > Hi

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-21 Thread Tim Chen
On Fri, 2017-04-21 at 20:29 +0800, Huang, Ying wrote: > "Huang, Ying" writes: > > > > > Minchan Kim writes: > > > > > > > > On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: > > > > > > > > Minchan Kim writes: > > > >

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-21 Thread Tim Chen
On Fri, 2017-04-21 at 20:29 +0800, Huang, Ying wrote: > "Huang, Ying" writes: > > > > > Minchan Kim writes: > > > > > > > > On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: > > > > > > > > Minchan Kim writes: > > > > > > > > > > > > > > Hi Huang, > > > > > > > > > > On Fri,

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-21 Thread Huang, Ying
"Huang, Ying" writes: > Minchan Kim writes: > >> On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: >>> Minchan Kim writes: >>> >>> > Hi Huang, >>> > >>> > On Fri, Apr 07, 2017 at 02:49:01PM +0800, Huang, Ying wrote: >>>

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-21 Thread Huang, Ying
"Huang, Ying" writes: > Minchan Kim writes: > >> On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: >>> Minchan Kim writes: >>> >>> > Hi Huang, >>> > >>> > On Fri, Apr 07, 2017 at 02:49:01PM +0800, Huang, Ying wrote: >>> >> From: Huang Ying >>> >> >>> >> void

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-20 Thread Huang, Ying
Minchan Kim writes: > On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: >> Minchan Kim writes: >> >> > Hi Huang, >> > >> > On Fri, Apr 07, 2017 at 02:49:01PM +0800, Huang, Ying wrote: >> >> From: Huang Ying >> >> >> >>

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-20 Thread Huang, Ying
Minchan Kim writes: > On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: >> Minchan Kim writes: >> >> > Hi Huang, >> > >> > On Fri, Apr 07, 2017 at 02:49:01PM +0800, Huang, Ying wrote: >> >> From: Huang Ying >> >> >> >> To reduce the lock contention of swap_info_struct->lock when

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-20 Thread Minchan Kim
On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: > Minchan Kim writes: > > > Hi Huang, > > > > On Fri, Apr 07, 2017 at 02:49:01PM +0800, Huang, Ying wrote: > >> From: Huang Ying > >> > >> To reduce the lock contention of

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-20 Thread Minchan Kim
On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: > Minchan Kim writes: > > > Hi Huang, > > > > On Fri, Apr 07, 2017 at 02:49:01PM +0800, Huang, Ying wrote: > >> From: Huang Ying > >> > >> To reduce the lock contention of swap_info_struct->lock when freeing > >> swap entry. The

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-19 Thread Huang, Ying
Minchan Kim writes: > Hi Huang, > > On Fri, Apr 07, 2017 at 02:49:01PM +0800, Huang, Ying wrote: >> From: Huang Ying >> >> To reduce the lock contention of swap_info_struct->lock when freeing >> swap entry. The freed swap entries will be collected in

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-19 Thread Huang, Ying
Minchan Kim writes: > Hi Huang, > > On Fri, Apr 07, 2017 at 02:49:01PM +0800, Huang, Ying wrote: >> From: Huang Ying >> >> To reduce the lock contention of swap_info_struct->lock when freeing >> swap entry. The freed swap entries will be collected in a per-CPU >> buffer firstly, and be really

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-17 Thread Minchan Kim
Hi Huang, On Fri, Apr 07, 2017 at 02:49:01PM +0800, Huang, Ying wrote: > From: Huang Ying > > To reduce the lock contention of swap_info_struct->lock when freeing > swap entry. The freed swap entries will be collected in a per-CPU > buffer firstly, and be really freed

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-17 Thread Minchan Kim
Hi Huang, On Fri, Apr 07, 2017 at 02:49:01PM +0800, Huang, Ying wrote: > From: Huang Ying > > To reduce the lock contention of swap_info_struct->lock when freeing > swap entry. The freed swap entries will be collected in a per-CPU > buffer firstly, and be really freed later in batch. During

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-13 Thread Huang, Ying
Andrew Morton writes: > On Fri, 7 Apr 2017 14:49:01 +0800 "Huang, Ying" wrote: > >> To reduce the lock contention of swap_info_struct->lock when freeing >> swap entry. The freed swap entries will be collected in a per-CPU >> buffer firstly, and

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-13 Thread Huang, Ying
Andrew Morton writes: > On Fri, 7 Apr 2017 14:49:01 +0800 "Huang, Ying" wrote: > >> To reduce the lock contention of swap_info_struct->lock when freeing >> swap entry. The freed swap entries will be collected in a per-CPU >> buffer firstly, and be really freed later in batch. During the

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-11 Thread Huang, Ying
Andrew Morton writes: > On Fri, 7 Apr 2017 14:49:01 +0800 "Huang, Ying" wrote: > >> To reduce the lock contention of swap_info_struct->lock when freeing >> swap entry. The freed swap entries will be collected in a per-CPU >> buffer firstly, and

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-11 Thread Huang, Ying
Andrew Morton writes: > On Fri, 7 Apr 2017 14:49:01 +0800 "Huang, Ying" wrote: > >> To reduce the lock contention of swap_info_struct->lock when freeing >> swap entry. The freed swap entries will be collected in a per-CPU >> buffer firstly, and be really freed later in batch. During the

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-07 Thread Andrew Morton
On Fri, 7 Apr 2017 14:49:01 +0800 "Huang, Ying" wrote: > To reduce the lock contention of swap_info_struct->lock when freeing > swap entry. The freed swap entries will be collected in a per-CPU > buffer firstly, and be really freed later in batch. During the batch >

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-07 Thread Andrew Morton
On Fri, 7 Apr 2017 14:49:01 +0800 "Huang, Ying" wrote: > To reduce the lock contention of swap_info_struct->lock when freeing > swap entry. The freed swap entries will be collected in a per-CPU > buffer firstly, and be really freed later in batch. During the batch > freeing, if the

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-07 Thread Rik van Riel
On Fri, 2017-04-07 at 14:49 +0800, Huang, Ying wrote: > To solve the issue, the per-CPU buffer is sorted according to the > swap > device before freeing the swap entries.  Test shows that the time > spent by swapcache_free_entries() could be reduced after the patch. > > Test the patch via

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-07 Thread Rik van Riel
On Fri, 2017-04-07 at 14:49 +0800, Huang, Ying wrote: > To solve the issue, the per-CPU buffer is sorted according to the > swap > device before freeing the swap entries.  Test shows that the time > spent by swapcache_free_entries() could be reduced after the patch. > > Test the patch via

[PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-07 Thread Huang, Ying
From: Huang Ying To reduce the lock contention of swap_info_struct->lock when freeing swap entry. The freed swap entries will be collected in a per-CPU buffer firstly, and be really freed later in batch. During the batch freeing, if the consecutive swap entries in the

[PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-07 Thread Huang, Ying
From: Huang Ying To reduce the lock contention of swap_info_struct->lock when freeing swap entry. The freed swap entries will be collected in a per-CPU buffer firstly, and be really freed later in batch. During the batch freeing, if the consecutive swap entries in the per-CPU buffer belongs to