Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-09 Thread Huang, Ying
Dave Hansen writes: > On 07/09/2018 06:19 PM, Huang, Ying wrote: >> Dave Hansen writes: >> config THP_SWAP def_bool y - depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP + depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP help >>> >>> This

Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-09 Thread Huang, Ying
Dave Hansen writes: > On 07/09/2018 06:19 PM, Huang, Ying wrote: >> Dave Hansen writes: >> config THP_SWAP def_bool y - depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP + depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP help >>> >>> This

Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-09 Thread Dave Hansen
On 07/09/2018 06:19 PM, Huang, Ying wrote: > Dave Hansen writes: > >>> config THP_SWAP >>> def_bool y >>> - depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP >>> + depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP >>> help >> >> This seems like a bug-fix. Is there

Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-09 Thread Dave Hansen
On 07/09/2018 06:19 PM, Huang, Ying wrote: > Dave Hansen writes: > >>> config THP_SWAP >>> def_bool y >>> - depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP >>> + depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP >>> help >> >> This seems like a bug-fix. Is there

Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-09 Thread Huang, Ying
Dave Hansen writes: >> config THP_SWAP >> def_bool y >> -depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP >> +depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP >> help > > > This seems like a bug-fix. Is there a reason this didn't cause problems > up to

Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-09 Thread Huang, Ying
Dave Hansen writes: >> config THP_SWAP >> def_bool y >> -depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP >> +depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP >> help > > > This seems like a bug-fix. Is there a reason this didn't cause problems > up to

Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-09 Thread Dave Hansen
> config THP_SWAP > def_bool y > - depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP > + depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP > help This seems like a bug-fix. Is there a reason this didn't cause problems up to now?

Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-09 Thread Dave Hansen
> config THP_SWAP > def_bool y > - depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP > + depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP > help This seems like a bug-fix. Is there a reason this didn't cause problems up to now?

Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-09 Thread Huang, Ying
Dan Williams writes: > On Thu, Jun 21, 2018 at 8:55 PM Huang, Ying wrote: >> >> From: Huang Ying >> >> It's unreasonable to optimize swapping for THP without basic swapping >> support. And this will cause build errors when THP_SWAP functions are >> defined in swapfile.c and called elsewhere.

Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-09 Thread Huang, Ying
Dan Williams writes: > On Thu, Jun 21, 2018 at 8:55 PM Huang, Ying wrote: >> >> From: Huang Ying >> >> It's unreasonable to optimize swapping for THP without basic swapping >> support. And this will cause build errors when THP_SWAP functions are >> defined in swapfile.c and called elsewhere.

Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-07 Thread Dan Williams
On Thu, Jun 21, 2018 at 8:55 PM Huang, Ying wrote: > > From: Huang Ying > > It's unreasonable to optimize swapping for THP without basic swapping > support. And this will cause build errors when THP_SWAP functions are > defined in swapfile.c and called elsewhere. > > The comments are fixed too

Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-07 Thread Dan Williams
On Thu, Jun 21, 2018 at 8:55 PM Huang, Ying wrote: > > From: Huang Ying > > It's unreasonable to optimize swapping for THP without basic swapping > support. And this will cause build errors when THP_SWAP functions are > defined in swapfile.c and called elsewhere. > > The comments are fixed too

[PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-06-21 Thread Huang, Ying
From: Huang Ying It's unreasonable to optimize swapping for THP without basic swapping support. And this will cause build errors when THP_SWAP functions are defined in swapfile.c and called elsewhere. The comments are fixed too to reflect the latest progress. Signed-off-by: "Huang, Ying" Cc:

[PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-06-21 Thread Huang, Ying
From: Huang Ying It's unreasonable to optimize swapping for THP without basic swapping support. And this will cause build errors when THP_SWAP functions are defined in swapfile.c and called elsewhere. The comments are fixed too to reflect the latest progress. Signed-off-by: "Huang, Ying" Cc: