Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread Andi Kleen
On Tuesday 09 October 2007 16:00:57 huang ying wrote: > On 10/9/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > > Care to add a line of documentation if you keep it in mm/memory.c? > > > > It would be better to just use early_ioremap() (or ioremap()) > > > > That is how ACPI who has similar issue

Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread huang ying
On 10/9/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > > > Care to add a line of documentation if you keep it in mm/memory.c? > > It would be better to just use early_ioremap() (or ioremap()) > > That is how ACPI who has similar issues accessing its tables solves this. Yes. That is another solution.

Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread Oleg Verych
* Tue, 09 Oct 2007 16:55:23 +0800 > > On Tue, 2007-10-09 at 02:06 +1000, Nick Piggin wrote: >> On Tuesday 09 October 2007 18:22, Huang, Ying wrote: [] >> I'm just wondering whether you really need to access highmem in >> boot code... > > Because the zero page (boot_parameters) of i386 boot protocol

Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread Andi Kleen
> Care to add a line of documentation if you keep it in mm/memory.c? It would be better to just use early_ioremap() (or ioremap()) That is how ACPI who has similar issues accessing its tables solves this. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bod

Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread Huang, Ying
On Tue, 2007-10-09 at 02:28 +1000, Nick Piggin wrote: > On Tuesday 09 October 2007 18:55, Huang, Ying wrote: > > On Tue, 2007-10-09 at 02:06 +1000, Nick Piggin wrote: > > > > I'm just wondering whether you really need to access highmem in > > > boot code... > > > > Because the zero page (boot_para

Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread Nick Piggin
On Tuesday 09 October 2007 18:55, Huang, Ying wrote: > On Tue, 2007-10-09 at 02:06 +1000, Nick Piggin wrote: > > I'm just wondering whether you really need to access highmem in > > boot code... > > Because the zero page (boot_parameters) of i386 boot protocol has 4k > limitation, a linked list sty

Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread Huang, Ying
On Tue, 2007-10-09 at 02:06 +1000, Nick Piggin wrote: > On Tuesday 09 October 2007 18:22, Huang, Ying wrote: > > On Tue, 2007-10-09 at 01:25 +1000, Nick Piggin wrote: > > > On Tuesday 09 October 2007 16:40, Huang, Ying wrote: > > > > +unsigned long copy_from_phys(void *to, unsigned long from_phys,

Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread Nick Piggin
On Tuesday 09 October 2007 18:22, Huang, Ying wrote: > On Tue, 2007-10-09 at 01:25 +1000, Nick Piggin wrote: > > On Tuesday 09 October 2007 16:40, Huang, Ying wrote: > > > +unsigned long copy_from_phys(void *to, unsigned long from_phys, > > > + unsigned long n) > > I suppose t

Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread Huang, Ying
On Tue, 2007-10-09 at 01:25 +1000, Nick Piggin wrote: > On Tuesday 09 October 2007 16:40, Huang, Ying wrote: > > > +unsigned long copy_from_phys(void *to, unsigned long from_phys, > > +unsigned long n) > > +{ > > + struct page *page; > > + void *from; > > + unsigned l

Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread Nick Piggin
On Tuesday 09 October 2007 16:40, Huang, Ying wrote: > +unsigned long copy_from_phys(void *to, unsigned long from_phys, > + unsigned long n) > +{ > + struct page *page; > + void *from; > + unsigned long remain = n, offset, trunck; > + > + while (remain) { >

[PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-08 Thread Huang, Ying
This patch add a field of 64-bit physical pointer to NULL terminated single linked list of struct setup_data to real-mode kernel header. This is used as a more extensible boot parameters passing mechanism. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/i386/Kconfig|3 -