Re: [PATCH -mm 2/2] PWM LED driver

2008-01-28 Thread David Brownell
On Monday 28 January 2008, Andrew Morton wrote: > > - if (i > 0) { > > - for (i = i - 1; i >= 0; i--) { > > - led_classdev_unregister(&leds[i].cdev); > > - pwm_channel_free(&leds[i].pwmc); > > - } > > + while (i-- > 0) { > > + 

Re: [PATCH -mm 2/2] PWM LED driver

2008-01-28 Thread Haavard Skinnemoen
On Mon, 28 Jan 2008 01:29:32 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > - if (i > 0) { > > - for (i = i - 1; i >= 0; i--) { > > - led_classdev_unregister(&leds[i].cdev); > > - pwm_channel_free(&leds[i].pwmc); > > - } > > + while (

Re: [PATCH -mm 2/2] PWM LED driver

2008-01-28 Thread Andrew Morton
On Mon, 28 Jan 2008 10:15:51 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > On Sun, 27 Jan 2008 21:32:32 -0800 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Thu, 24 Jan 2008 15:33:45 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> > > wrote: > > > > > + if (i > 0) { > > > + fo

Re: [PATCH -mm 2/2] PWM LED driver

2008-01-28 Thread Haavard Skinnemoen
On Sun, 27 Jan 2008 21:32:32 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 24 Jan 2008 15:33:45 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> > wrote: > > > + if (i > 0) { > > + for (i = i - 1; i >= 0; i--) { > > + led_classdev_unregister(&leds[i].cdev); >

Re: [PATCH -mm 2/2] PWM LED driver

2008-01-27 Thread Andrew Morton
On Thu, 24 Jan 2008 15:33:45 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > + if (i > 0) { > + for (i = i - 1; i >= 0; i--) { > + led_classdev_unregister(&leds[i].cdev); > + pwm_channel_free(&leds[i].pwmc); > + } > + }

[PATCH -mm 2/2] PWM LED driver

2008-01-24 Thread Haavard Skinnemoen
From: David Brownell <[EMAIL PROTECTED]> This is a LED driver using the PWM on newer SOCs from Atmel; brightness is controlled by changing the PWM duty cycle. So for example if you've set up two leds labeled "pwm0" and "pwm1": echo 0 > /sys/class/leds/pwm2/brightness# off (0%)