Re: [PATCH -mm 2/2 -v2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-18 Thread Simon Horman
On Tue, Jan 15, 2008 at 02:05:49PM +0800, Huang, Ying wrote: > This patch transforms the kexec page tables setup code from assembler > code to C code in machine_kexec_prepare. This improves readability and > reduces code line number. This looks good to me. Simon Horman <[EMAIL PROTECTED]> >

Re: [PATCH -mm 2/2 -v2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-18 Thread Simon Horman
On Tue, Jan 15, 2008 at 02:05:49PM +0800, Huang, Ying wrote: This patch transforms the kexec page tables setup code from assembler code to C code in machine_kexec_prepare. This improves readability and reduces code line number. This looks good to me. Simon Horman [EMAIL PROTECTED]

Re: [PATCH -mm 2/2 -v2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-15 Thread Vivek Goyal
On Tue, Jan 15, 2008 at 02:05:49PM +0800, Huang, Ying wrote: > This patch transforms the kexec page tables setup code from assembler > code to C code in machine_kexec_prepare. This improves readability and > reduces code line number. > > Signed-off-by: Huang Ying <[EMAIL PROTECTED]> > Looks

Re: [PATCH -mm 2/2 -v2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-15 Thread Vivek Goyal
On Tue, Jan 15, 2008 at 02:05:49PM +0800, Huang, Ying wrote: This patch transforms the kexec page tables setup code from assembler code to C code in machine_kexec_prepare. This improves readability and reduces code line number. Signed-off-by: Huang Ying [EMAIL PROTECTED] Looks good to me.

[PATCH -mm 2/2 -v2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-14 Thread Huang, Ying
This patch transforms the kexec page tables setup code from assembler code to C code in machine_kexec_prepare. This improves readability and reduces code line number. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/kernel/machine_kexec_32.c | 59 ++

[PATCH -mm 2/2 -v2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-14 Thread Huang, Ying
This patch transforms the kexec page tables setup code from assembler code to C code in machine_kexec_prepare. This improves readability and reduces code line number. Signed-off-by: Huang Ying [EMAIL PROTECTED] --- arch/x86/kernel/machine_kexec_32.c | 59 ++