Re: [PATCH -mm 2/9] netconsole: Code simplification

2007-07-04 Thread Satyam Sharma
On Wed, 4 Jul 2007, Matt Mackall wrote: > On Wed, Jul 04, 2007 at 04:37:49PM +0530, Satyam Sharma wrote: > > [...] > > (2) With this change, option_setup() is not required for modular netconsole. > > How is this a simplification? You've taken code with no #ifdefs and > added one! Please have both

Re: [PATCH -mm 2/9] netconsole: Code simplification

2007-07-04 Thread Matt Mackall
On Wed, Jul 04, 2007 at 04:37:49PM +0530, Satyam Sharma wrote: > From: Satyam Sharma <[EMAIL PROTECTED]> > > [2/9] netconsole: Code simplification > > (1) Extract netpoll_parse_options() out of option_setup(), and into > init_netconsole() itself. So "configured" variable is redundant and > can be

[PATCH -mm 2/9] netconsole: Code simplification

2007-07-04 Thread Satyam Sharma
From: Satyam Sharma <[EMAIL PROTECTED]> [2/9] netconsole: Code simplification (1) Extract netpoll_parse_options() out of option_setup(), and into init_netconsole() itself. So "configured" variable is redundant and can be removed. (2) With this change, option_setup() is not required for modular n