Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification

2007-01-25 Thread Sébastien Dugué
On Thu, 25 Jan 2007 05:42:42 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Wed, Jan 24, 2007 at 12:11:30PM +0100, S?bastien Dugu? wrote: > > > > + if (unlikely(!notify->sigq)) > > > > + return -EAGAIN; > > > > > > Did this just leak a ref on the task_struct? > > > >

Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification

2007-01-24 Thread Christoph Hellwig
On Wed, Jan 24, 2007 at 12:11:30PM +0100, S?bastien Dugu? wrote: > > > + if (unlikely(!notify->sigq)) > > > + return -EAGAIN; > > > > Did this just leak a ref on the task_struct? > > > > No, the ref is released in really_put_req() when we dispose of > the iocb. And the code really nee

Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification

2007-01-24 Thread Sébastien Dugué
On Tue, 23 Jan 2007 21:35:13 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 17 Jan 2007 10:50:18 +0100 > Sébastien Dugué <[EMAIL PROTECTED]> wrote: > > > +static long aio_setup_sigevent(struct aio_notify *notify, > > + struct sigevent __user *user_event) > > +{

Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification

2007-01-23 Thread Andrew Morton
On Wed, 17 Jan 2007 10:50:18 +0100 Sébastien Dugué <[EMAIL PROTECTED]> wrote: > +static long aio_setup_sigevent(struct aio_notify *notify, > +struct sigevent __user *user_event) > +{ > + sigevent_t event; > + struct task_struct *target; > + > + if (copy_from

[PATCH -mm 4/5][AIO] - AIO completion signal notification

2007-01-17 Thread Sébastien Dugué
AIO completion signal notification The current 2.6 kernel does not support notification of user space via an RT signal upon an asynchronous IO completion. The POSIX specification states that when an AIO request completes, a signal can be delivered to the application as not

Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification

2006-11-30 Thread Sébastien Dugué
AIO completion signal notification The current 2.6 kernel does not support notification of user space via an RT signal upon an asynchronous IO completion. The POSIX specification states that when an AIO request completes, a signal can be delivered to the application as not

Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification

2006-11-29 Thread Sébastien Dugué
On Wed, 29 Nov 2006 13:50:12 +, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Wed, Nov 29, 2006 at 02:08:01PM +0100, S?bastien Dugu? wrote: > > On Wed, 29 Nov 2006 10:51:50 +, Christoph Hellwig <[EMAIL PROTECTED]> > > wrote: > > > > > I'm a little bit unhappy about the usage of the n

Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification

2006-11-29 Thread Christoph Hellwig
On Wed, Nov 29, 2006 at 02:08:01PM +0100, S?bastien Dugu? wrote: > On Wed, 29 Nov 2006 10:51:50 +, Christoph Hellwig <[EMAIL PROTECTED]> > wrote: > > > I'm a little bit unhappy about the usage of the notify flag. The usage > > seems correct but very confusing: > > Well, I followed the log

Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification

2006-11-29 Thread Sébastien Dugué
On Wed, 29 Nov 2006 06:33:35 -0500, Jakub Jelinek <[EMAIL PROTECTED]> wrote: > On Wed, Nov 29, 2006 at 11:33:01AM +0100, S?bastien Dugu? wrote: > > AIO completion signal notification > > > > The current 2.6 kernel does not support notification of user space via > > an RT s

Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification

2006-11-29 Thread Sébastien Dugué
On Wed, 29 Nov 2006 10:51:50 +, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > I'm a little bit unhappy about the usage of the notify flag. The usage > seems correct but very confusing: Well, I followed the logic from posix-timers.c, but it may be a poor choice ;-) For a start, the SIGE

Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification

2006-11-29 Thread Jakub Jelinek
On Wed, Nov 29, 2006 at 11:33:01AM +0100, S?bastien Dugu? wrote: > AIO completion signal notification > > The current 2.6 kernel does not support notification of user space via > an RT signal upon an asynchronous IO completion. The POSIX specification > states that when an

Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification

2006-11-29 Thread Christoph Hellwig
I'm a little bit unhappy about the usage of the notify flag. The usage seems correct but very confusing: In io_submit_one we set ki_notify.notify to SIGEV_NONE and possibly call aio_setup_sigevent: > + /* handle setting up the sigevent for POSIX AIO signals */ > + req->ki_notify.notify =

[PATCH -mm 4/5][AIO] - AIO completion signal notification

2006-11-29 Thread Sébastien Dugué
AIO completion signal notification The current 2.6 kernel does not support notification of user space via an RT signal upon an asynchronous IO completion. The POSIX specification states that when an AIO request completes, a signal can be delivered to the application as not