Re: [PATCH -mm 4/5] Blackfin: patch add blackfin support in smc91x ethernet controller driver

2007-03-01 Thread Wu, Bryan
On Thu, 2007-03-01 at 02:03 -0800, Andrew Morton wrote: > On Thu, 01 Mar 2007 17:52:48 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote: > > > > Please always prefer coding in C over coding in cpp. > > > > Yes, it can be writen as a C function. > > We just follow other implementation in the drivers/ne

Re: [PATCH -mm 4/5] Blackfin: patch add blackfin support in smc91x ethernet controller driver

2007-03-01 Thread Andrew Morton
On Thu, 01 Mar 2007 17:52:48 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote: > > Please always prefer coding in C over coding in cpp. > > Yes, it can be writen as a C function. > We just follow other implementation in the drivers/net/smc91x.h > > start at line 1156 of > --- > #ifndef SMC_GET_MAC_AD

Re: [PATCH -mm 4/5] Blackfin: patch add blackfin support in smc91x ethernet controller driver

2007-03-01 Thread Andrew Morton
oh, and please consider removing all the CVS control strings from the blackfin code. Because they become meaningless once the code is merged into mainline. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH -mm 4/5] Blackfin: patch add blackfin support in smc91x ethernet controller driver

2007-03-01 Thread Wu, Bryan
On Thu, 2007-03-01 at 01:32 -0800, Andrew Morton wrote: > On Thu, 01 Mar 2007 17:23:23 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote: > > > On Thu, 2007-03-01 at 00:54 -0800, Andrew Morton wrote: > > > On Thu, 01 Mar 2007 12:15:29 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote: > > > > > > > +/* check

Re: [PATCH -mm 4/5] Blackfin: patch add blackfin support in smc91x ethernet controller driver

2007-03-01 Thread Andrew Morton
On Thu, 01 Mar 2007 17:23:23 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote: > On Thu, 2007-03-01 at 00:54 -0800, Andrew Morton wrote: > > On Thu, 01 Mar 2007 12:15:29 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote: > > > > > +/* check if the mac in reg is valid */ > > > +#define SMC_GET_MAC_ADDR(addr)

Re: [PATCH -mm 4/5] Blackfin: patch add blackfin support in smc91x ethernet controller driver

2007-03-01 Thread Wu, Bryan
On Thu, 2007-03-01 at 00:54 -0800, Andrew Morton wrote: > On Thu, 01 Mar 2007 12:15:29 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote: > > > +/* check if the mac in reg is valid */ > > +#define SMC_GET_MAC_ADDR(addr) \ > > + do {

Re: [PATCH -mm 4/5] Blackfin: patch add blackfin support in smc91x ethernet controller driver

2007-03-01 Thread Andrew Morton
On Thu, 01 Mar 2007 12:15:29 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote: > +/* check if the mac in reg is valid */ > +#define SMC_GET_MAC_ADDR(addr) \ > + do {\ > + unsigned int __v;

[PATCH -mm 4/5] Blackfin: patch add blackfin support in smc91x ethernet controller driver

2007-02-28 Thread Wu, Bryan
Hi folks, As SMC91X ethernet controller are used in blackfin STAMP 533 development board, this patch add blackfin support to the smc91x linux driver. It's name is blackfin-driver-net-stamp533.patch. [PATCH] Blackfin: patch add blackfin support in smc91x ethernet controller driver Signed-off-by