Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-07 Thread Satyam Sharma
Hi Keiichi, On Sun, 8 Jul 2007, KII Keiichi wrote: > Hi Satyam, > > > After more discussion, Joel suggested the idea to separately manage the > > lifetimes of the two kinds of netconsole_target objects, those created while > > parsing boot/module options and those created via configfs mkdir(2) fr

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-07 Thread KII Keiichi
Hi Satyam, > After more discussion, Joel suggested the idea to separately manage the > lifetimes of the two kinds of netconsole_target objects, those created while > parsing boot/module options and those created via configfs mkdir(2) from > userspace, in my driver itself. That adds a little bit of

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-07 Thread Joel Becker
On Sat, Jul 07, 2007 at 01:18:45PM +0530, Satyam Sharma wrote: > However, for items that are statically initialized (often the > group->cg_item members of subsystems or default groups) we often simply > set ci_namebuf and then call config_item_init() -- say via > config_group_init(), like I've done

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-07 Thread Satyam Sharma
Hi Joel, On Fri, 6 Jul 2007, Joel Becker wrote: > On Wed, Jul 04, 2007 at 04:38:24PM +0530, Satyam Sharma wrote: > > struct netconsole_target { > > struct list_headlist; > > + struct config_item item; > > + int id; > > + int enabled;

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-06 Thread Joel Becker
On Wed, Jul 04, 2007 at 04:38:24PM +0530, Satyam Sharma wrote: > struct netconsole_target { > struct list_headlist; > + struct config_item item; > + int id; > + int enabled; > int dev_status; > s

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-04 Thread Satyam Sharma
[ Some more thoughts I had on this, for those interested. ] > +#ifdef CONFIG_NETCONSOLE_DYNAMIC > + > +/* > + * Targets that were created by parsing the boot/module option string > + * do not exist in the configfs hierarchy and will never go away (and > + * have zeroed-out config_item member

[PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-04 Thread Satyam Sharma
From: Satyam Sharma <[EMAIL PROTECTED]> [9/9] netconsole: Support dynamic reconfiguration using configfs This patch introduces support for dynamic reconfiguration (adding, removing and/or modifying parameters of netconsole targets at runtime) using a userspace interface exported via configfs. Is