Re: [PATCH -mm v2 3/7] cgroup: release css->id after css_free

2015-01-19 Thread Tejun Heo
On Mon, Jan 19, 2015 at 06:18:54PM +0300, Vladimir Davydov wrote: > Could you please elaborate this? I mean, what problems do you think can > arise if we release css->id a little bit (one grace period) later? > > Of course, I can introduce yet another id per memcg, but I think we have > css->id

Re: [PATCH -mm v2 3/7] cgroup: release css->id after css_free

2015-01-19 Thread Vladimir Davydov
Hi Tejun, On Mon, Jan 19, 2015 at 09:30:01AM -0500, Tejun Heo wrote: > On Mon, Jan 19, 2015 at 02:23:21PM +0300, Vladimir Davydov wrote: > > Currently, we release css->id in css_release_work_fn, right before > > calling css_free callback, so that when css_free is called, the id may > > have

Re: [PATCH -mm v2 3/7] cgroup: release css->id after css_free

2015-01-19 Thread Tejun Heo
On Mon, Jan 19, 2015 at 02:23:21PM +0300, Vladimir Davydov wrote: > Currently, we release css->id in css_release_work_fn, right before > calling css_free callback, so that when css_free is called, the id may > have already been reused for a new cgroup. > > I am going to use css->id to create

[PATCH -mm v2 3/7] cgroup: release css->id after css_free

2015-01-19 Thread Vladimir Davydov
Currently, we release css->id in css_release_work_fn, right before calling css_free callback, so that when css_free is called, the id may have already been reused for a new cgroup. I am going to use css->id to create unique names for per memcg kmem caches. Since kmem caches are destroyed only on

Re: [PATCH -mm v2 3/7] cgroup: release css-id after css_free

2015-01-19 Thread Tejun Heo
On Mon, Jan 19, 2015 at 02:23:21PM +0300, Vladimir Davydov wrote: Currently, we release css-id in css_release_work_fn, right before calling css_free callback, so that when css_free is called, the id may have already been reused for a new cgroup. I am going to use css-id to create unique

Re: [PATCH -mm v2 3/7] cgroup: release css-id after css_free

2015-01-19 Thread Vladimir Davydov
Hi Tejun, On Mon, Jan 19, 2015 at 09:30:01AM -0500, Tejun Heo wrote: On Mon, Jan 19, 2015 at 02:23:21PM +0300, Vladimir Davydov wrote: Currently, we release css-id in css_release_work_fn, right before calling css_free callback, so that when css_free is called, the id may have already been

Re: [PATCH -mm v2 3/7] cgroup: release css-id after css_free

2015-01-19 Thread Tejun Heo
On Mon, Jan 19, 2015 at 06:18:54PM +0300, Vladimir Davydov wrote: Could you please elaborate this? I mean, what problems do you think can arise if we release css-id a little bit (one grace period) later? Of course, I can introduce yet another id per memcg, but I think we have css-id to avoid

[PATCH -mm v2 3/7] cgroup: release css-id after css_free

2015-01-19 Thread Vladimir Davydov
Currently, we release css-id in css_release_work_fn, right before calling css_free callback, so that when css_free is called, the id may have already been reused for a new cgroup. I am going to use css-id to create unique names for per memcg kmem caches. Since kmem caches are destroyed only on