Re: [PATCH -mmotm] efi: drop kmemleak_ignore() for page allocator

2018-12-29 Thread Qian Cai
On 12/29/18 4:17 AM, Ard Biesheuvel wrote: > On Fri, 28 Dec 2018 at 04:04, Andrew Morton wrote: >> >> On Wed, 26 Dec 2018 16:31:59 +0100 Ard Biesheuvel >> wrote: >> >>> Please stop sending EFI patches if you can't be bothered to >>> test/reproduce against the EFI tree. >> >> um, sorry, but that'

Re: [PATCH -mmotm] efi: drop kmemleak_ignore() for page allocator

2018-12-29 Thread Ard Biesheuvel
On Fri, 28 Dec 2018 at 04:04, Andrew Morton wrote: > > On Wed, 26 Dec 2018 16:31:59 +0100 Ard Biesheuvel > wrote: > > > Please stop sending EFI patches if you can't be bothered to > > test/reproduce against the EFI tree. > > um, sorry, but that's a bit strong. Finding (let alone fixing) a bug >

Re: [PATCH -mmotm] efi: drop kmemleak_ignore() for page allocator

2018-12-27 Thread Andrew Morton
On Wed, 26 Dec 2018 16:31:59 +0100 Ard Biesheuvel wrote: > Please stop sending EFI patches if you can't be bothered to > test/reproduce against the EFI tree. um, sorry, but that's a bit strong. Finding (let alone fixing) a bug in EFI is a great contribution (thanks!) and the EFI maintainers ar

Re: [PATCH -mmotm] efi: drop kmemleak_ignore() for page allocator

2018-12-26 Thread Ard Biesheuvel
On Wed, 26 Dec 2018 at 16:13, Qian Cai wrote: > > On 12/26/18 7:02 AM, Ard Biesheuvel wrote: > > On Wed, 26 Dec 2018 at 03:35, Qian Cai wrote: > >> > >> a0fc5578f1d (efi: Let kmemleak ignore false positives) is no longer > >> needed due to efi_mem_reserve_persistent() uses __get_free_page() > >>

Re: [PATCH -mmotm] efi: drop kmemleak_ignore() for page allocator

2018-12-26 Thread Qian Cai
On 12/26/18 7:02 AM, Ard Biesheuvel wrote: > On Wed, 26 Dec 2018 at 03:35, Qian Cai wrote: >> >> a0fc5578f1d (efi: Let kmemleak ignore false positives) is no longer >> needed due to efi_mem_reserve_persistent() uses __get_free_page() >> instead where kmemelak is not able to track regardless. Other

Re: [PATCH -mmotm] efi: drop kmemleak_ignore() for page allocator

2018-12-26 Thread Ard Biesheuvel
On Wed, 26 Dec 2018 at 03:35, Qian Cai wrote: > > a0fc5578f1d (efi: Let kmemleak ignore false positives) is no longer > needed due to efi_mem_reserve_persistent() uses __get_free_page() > instead where kmemelak is not able to track regardless. Otherwise, > kernel reported "kmemleak: Trying to colo

[PATCH -mmotm] efi: drop kmemleak_ignore() for page allocator

2018-12-25 Thread Qian Cai
a0fc5578f1d (efi: Let kmemleak ignore false positives) is no longer needed due to efi_mem_reserve_persistent() uses __get_free_page() instead where kmemelak is not able to track regardless. Otherwise, kernel reported "kmemleak: Trying to color unknown object at 0x801060ef as Black" Signed-