Re: [PATCH -next] IB/qib: Add missing err handle for qib_user_sdma_rb_insert

2019-01-04 Thread Jason Gunthorpe
On Fri, Jan 04, 2019 at 06:39:50PM +, Marciniszyn, Mike wrote: > > diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c > > b/drivers/infiniband/hw/qib/qib_user_sdma.c > > index 31c523b..e87c0a7 100644 > > +++ b/drivers/infiniband/hw/qib/qib_user_sdma.c > > @@ -237,6 +237,8 @@ qib_user_sdma_q

RE: [PATCH -next] IB/qib: Add missing err handle for qib_user_sdma_rb_insert

2019-01-04 Thread Marciniszyn, Mike
> diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c > b/drivers/infiniband/hw/qib/qib_user_sdma.c > index 31c523b..e87c0a7 100644 > --- a/drivers/infiniband/hw/qib/qib_user_sdma.c > +++ b/drivers/infiniband/hw/qib/qib_user_sdma.c > @@ -237,6 +237,8 @@ qib_user_sdma_queue_create(struct device *

Re: [PATCH -next] IB/qib: Add missing err handle for qib_user_sdma_rb_insert

2019-01-03 Thread YueHaibing
On 2019/1/3 3:22, Leon Romanovsky wrote:> On Wed, Jan 02, 2019 at 12:07:40PM -0700, Jason Gunthorpe wrote: >> On Wed, Jan 02, 2019 at 08:40:50PM +0200, Leon Romanovsky wrote: >>> On Wed, Jan 02, 2019 at 10:12:24AM -0700, Jason Gunthorpe wrote: On Fri, Dec 21, 2018 at 10:19:38AM +0800, YueHa

Re: [PATCH -next] IB/qib: Add missing err handle for qib_user_sdma_rb_insert

2019-01-02 Thread YueHaibing
On 2019/1/3 3:07, Jason Gunthorpe wrote: > On Wed, Jan 02, 2019 at 08:40:50PM +0200, Leon Romanovsky wrote: >> On Wed, Jan 02, 2019 at 10:12:24AM -0700, Jason Gunthorpe wrote: >>> On Fri, Dec 21, 2018 at 10:19:38AM +0800, YueHaibing wrote: It should goto err handle if qib_user_sdma_rb_insert f

Re: [PATCH -next] IB/qib: Add missing err handle for qib_user_sdma_rb_insert

2019-01-02 Thread Leon Romanovsky
On Wed, Jan 02, 2019 at 12:07:40PM -0700, Jason Gunthorpe wrote: > On Wed, Jan 02, 2019 at 08:40:50PM +0200, Leon Romanovsky wrote: > > On Wed, Jan 02, 2019 at 10:12:24AM -0700, Jason Gunthorpe wrote: > > > On Fri, Dec 21, 2018 at 10:19:38AM +0800, YueHaibing wrote: > > > > It should goto err handl

Re: [PATCH -next] IB/qib: Add missing err handle for qib_user_sdma_rb_insert

2019-01-02 Thread Jason Gunthorpe
On Wed, Jan 02, 2019 at 08:40:50PM +0200, Leon Romanovsky wrote: > On Wed, Jan 02, 2019 at 10:12:24AM -0700, Jason Gunthorpe wrote: > > On Fri, Dec 21, 2018 at 10:19:38AM +0800, YueHaibing wrote: > > > It should goto err handle if qib_user_sdma_rb_insert fails, > > > other than success return. > >

Re: [PATCH -next] IB/qib: Add missing err handle for qib_user_sdma_rb_insert

2019-01-02 Thread Leon Romanovsky
On Wed, Jan 02, 2019 at 10:12:24AM -0700, Jason Gunthorpe wrote: > On Fri, Dec 21, 2018 at 10:19:38AM +0800, YueHaibing wrote: > > It should goto err handle if qib_user_sdma_rb_insert fails, > > other than success return. > > > > Fixes: 67810e8c3c01 ("RDMA/qib: Remove all occurrences of BUG_ON()")

Re: [PATCH -next] IB/qib: Add missing err handle for qib_user_sdma_rb_insert

2019-01-02 Thread Jason Gunthorpe
On Fri, Dec 21, 2018 at 10:19:38AM +0800, YueHaibing wrote: > It should goto err handle if qib_user_sdma_rb_insert fails, > other than success return. > > Fixes: 67810e8c3c01 ("RDMA/qib: Remove all occurrences of BUG_ON()") > Signed-off-by: YueHaibing > --- > drivers/infiniband/hw/qib/qib_user_s

[PATCH -next] IB/qib: Add missing err handle for qib_user_sdma_rb_insert

2018-12-20 Thread YueHaibing
It should goto err handle if qib_user_sdma_rb_insert fails, other than success return. Fixes: 67810e8c3c01 ("RDMA/qib: Remove all occurrences of BUG_ON()") Signed-off-by: YueHaibing --- drivers/infiniband/hw/qib/qib_user_sdma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infini