Re: [PATCH -next] NFSD: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Chuck Lever III
Hello- > On Apr 6, 2021, at 8:08 AM, Huang Guobin wrote: > > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed-off-by: Guobin Huang This change has been pushed to t

Re: [PATCH -next] NFSD: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Bruce Fields
On Tue, Apr 06, 2021 at 03:46:34PM +, Chuck Lever III wrote: > > > > On Apr 6, 2021, at 8:08 AM, Huang Guobin wrote: > > > > From: Guobin Huang > > > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > > rather than explicitly calling spin_lock_init(). > > > > Reported-b

Re: [PATCH -next] NFSD: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Chuck Lever III
> On Apr 6, 2021, at 8:08 AM, Huang Guobin wrote: > > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed-off-by: Guobin Huang This same patch was sent last July, w

[PATCH -next] NFSD: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- fs/nfsd/nfssvc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/nfsd/nfssvc.c

Re: [PATCH -next] nfsd: use DEFINE_SPINLOCK() for spinlock

2020-07-31 Thread Chuck Lever
Hello- > On Jul 25, 2020, at 4:56 AM, Qinglang Miao wrote: > > nfsd_drc_lock can be initialized automatically with > DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). > > Signed-off-by: Qinglang Miao Thanks for your patch. I am quite honestly on the fence about this one. It

[PATCH -next] nfsd: use DEFINE_SPINLOCK() for spinlock

2020-07-25 Thread Qinglang Miao
nfsd_drc_lock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Signed-off-by: Qinglang Miao --- fs/nfsd/nfssvc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c index b603dfcdd..20f0