Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-17 Thread Will Deacon
On Tue, Jun 18, 2019 at 09:12:59AM +0300, Mike Rapoport wrote: > On Mon, Jun 17, 2019 at 05:36:30PM +0100, Will Deacon wrote: > > On Mon, Jun 17, 2019 at 06:12:52PM +0300, Mike Rapoport wrote: > > > Andrew, can you please add the patch below as an incremental fix? > > > > > > With this the arm64::

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-17 Thread Mike Rapoport
On Mon, Jun 17, 2019 at 05:36:30PM +0100, Will Deacon wrote: > Hi Mike, > > On Mon, Jun 17, 2019 at 06:12:52PM +0300, Mike Rapoport wrote: > > Andrew, can you please add the patch below as an incremental fix? > > > > With this the arm64::pgd_alloc() should be in the right shape. > > > > > > Fro

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-17 Thread Will Deacon
Hi Mike, On Mon, Jun 17, 2019 at 06:12:52PM +0300, Mike Rapoport wrote: > Andrew, can you please add the patch below as an incremental fix? > > With this the arm64::pgd_alloc() should be in the right shape. > > > From 1c1ef0bc04c655689c6c527bd03b140251399d87 Mon Sep 17 00:00:00 2001 > From: Mik

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-17 Thread Mike Rapoport
On Thu, Jun 13, 2019 at 03:11:01PM +0300, Mike Rapoport wrote: > On Tue, Jun 11, 2019 at 11:03:49AM +0100, Mark Rutland wrote: > > On Mon, Jun 10, 2019 at 01:26:15PM -0400, Qian Cai wrote: > > > On Mon, 2019-06-10 at 12:43 +0100, Will Deacon wrote: > > > > On Tue, Jun 04, 2019 at 03:23:38PM +0100,

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-13 Thread Mike Rapoport
On Thu, Jun 13, 2019 at 09:22:36AM -0400, Qian Cai wrote: > On Thu, 2019-06-13 at 15:11 +0300, Mike Rapoport wrote: > > The log Qian Cai posted at [1] and partially cited below confirms that the > > failure happens when *user* PGDs are allocated and the addition of > > __GFP_ACCOUNT to gfp flags us

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-13 Thread Mike Rapoport
(added Roman) On Tue, Jun 11, 2019 at 11:03:49AM +0100, Mark Rutland wrote: > On Mon, Jun 10, 2019 at 01:26:15PM -0400, Qian Cai wrote: > > On Mon, 2019-06-10 at 12:43 +0100, Will Deacon wrote: > > > On Tue, Jun 04, 2019 at 03:23:38PM +0100, Mark Rutland wrote: > > > > On Tue, Jun 04, 2019 at 10:0

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-13 Thread Qian Cai
On Thu, 2019-06-13 at 15:11 +0300, Mike Rapoport wrote: > The log Qian Cai posted at [1] and partially cited below confirms that the > failure happens when *user* PGDs are allocated and the addition of > __GFP_ACCOUNT to gfp flags used by pgd_alloc() only uncovered another > issue. > > I'm still f

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-12 Thread Qian Cai
On Wed, 2019-06-12 at 09:57 +0300, Mike Rapoport wrote: > Hi, > > On Tue, Jun 11, 2019 at 08:46:45AM -0400, Qian Cai wrote: > > > > > On Jun 11, 2019, at 8:41 AM, Mike Rapoport wrote: > > > > > > Sorry for the delay, I'm mostly offline these days. > > > > > > I wanted to understand first what

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-11 Thread Mike Rapoport
Hi, On Tue, Jun 11, 2019 at 08:46:45AM -0400, Qian Cai wrote: > > > On Jun 11, 2019, at 8:41 AM, Mike Rapoport wrote: > > > > Sorry for the delay, I'm mostly offline these days. > > > > I wanted to understand first what is the reason for the failure. I've tried > > to reproduce it with qemu, b

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-11 Thread Mark Rutland
On Tue, Jun 11, 2019 at 03:41:19PM +0300, Mike Rapoport wrote: > On Tue, Jun 11, 2019 at 11:03:49AM +0100, Mark Rutland wrote: > > On Mon, Jun 10, 2019 at 01:26:15PM -0400, Qian Cai wrote: > > > On Mon, 2019-06-10 at 12:43 +0100, Will Deacon wrote: > > > > On Tue, Jun 04, 2019 at 03:23:38PM +0100,

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-11 Thread Qian Cai
> On Jun 11, 2019, at 8:41 AM, Mike Rapoport wrote: > > On Tue, Jun 11, 2019 at 11:03:49AM +0100, Mark Rutland wrote: >> On Mon, Jun 10, 2019 at 01:26:15PM -0400, Qian Cai wrote: >>> On Mon, 2019-06-10 at 12:43 +0100, Will Deacon wrote: On Tue, Jun 04, 2019 at 03:23:38PM +0100, Mark Rutla

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-11 Thread Mike Rapoport
On Tue, Jun 11, 2019 at 11:03:49AM +0100, Mark Rutland wrote: > On Mon, Jun 10, 2019 at 01:26:15PM -0400, Qian Cai wrote: > > On Mon, 2019-06-10 at 12:43 +0100, Will Deacon wrote: > > > On Tue, Jun 04, 2019 at 03:23:38PM +0100, Mark Rutland wrote: > > > > On Tue, Jun 04, 2019 at 10:00:36AM -0400, Q

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-11 Thread Mark Rutland
On Mon, Jun 10, 2019 at 01:26:15PM -0400, Qian Cai wrote: > On Mon, 2019-06-10 at 12:43 +0100, Will Deacon wrote: > > On Tue, Jun 04, 2019 at 03:23:38PM +0100, Mark Rutland wrote: > > > On Tue, Jun 04, 2019 at 10:00:36AM -0400, Qian Cai wrote: > > > > The commit "arm64: switch to generic version of

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-10 Thread Qian Cai
On Mon, 2019-06-10 at 12:43 +0100, Will Deacon wrote: > On Tue, Jun 04, 2019 at 03:23:38PM +0100, Mark Rutland wrote: > > On Tue, Jun 04, 2019 at 10:00:36AM -0400, Qian Cai wrote: > > > The commit "arm64: switch to generic version of pte allocation" > > > introduced endless failures during boot lik

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-10 Thread Will Deacon
On Tue, Jun 04, 2019 at 03:23:38PM +0100, Mark Rutland wrote: > On Tue, Jun 04, 2019 at 10:00:36AM -0400, Qian Cai wrote: > > The commit "arm64: switch to generic version of pte allocation" > > introduced endless failures during boot like, > > > > kobject_add_internal failed for pgd_cache(285:chro

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-05 Thread Mike Rapoport
On Tue, Jun 04, 2019 at 03:30:20PM +0100, Mark Rutland wrote: > On Tue, Jun 04, 2019 at 03:23:38PM +0100, Mark Rutland wrote: > > On Tue, Jun 04, 2019 at 10:00:36AM -0400, Qian Cai wrote: > > > The commit "arm64: switch to generic version of pte allocation" > > > introduced endless failures during

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-04 Thread Mike Rapoport
On Tue, Jun 04, 2019 at 03:23:38PM +0100, Mark Rutland wrote: > On Tue, Jun 04, 2019 at 10:00:36AM -0400, Qian Cai wrote: > > The commit "arm64: switch to generic version of pte allocation" > > introduced endless failures during boot like, > > > > kobject_add_internal failed for pgd_cache(285:chro

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-04 Thread Mark Rutland
On Tue, Jun 04, 2019 at 03:23:38PM +0100, Mark Rutland wrote: > On Tue, Jun 04, 2019 at 10:00:36AM -0400, Qian Cai wrote: > > The commit "arm64: switch to generic version of pte allocation" > > introduced endless failures during boot like, > > > > kobject_add_internal failed for pgd_cache(285:chro

Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-04 Thread Mark Rutland
On Tue, Jun 04, 2019 at 10:00:36AM -0400, Qian Cai wrote: > The commit "arm64: switch to generic version of pte allocation" > introduced endless failures during boot like, > > kobject_add_internal failed for pgd_cache(285:chronyd.service) (error: > -2 parent: cgroup) > > It turns out __GFP_ACCOUN

[PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()

2019-06-04 Thread Qian Cai
The commit "arm64: switch to generic version of pte allocation" introduced endless failures during boot like, kobject_add_internal failed for pgd_cache(285:chronyd.service) (error: -2 parent: cgroup) It turns out __GFP_ACCOUNT is passed to kernel page table allocations and then later memcg finds