Re: [PATCH -next] clocksource: keystone: Fix return value check in keystone_timer_init()

2014-01-16 Thread Daniel Lezcano
On 01/16/2014 09:29 AM, Wei Yongjun wrote: From: Wei Yongjun In case of error, function of_clk_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/clocksource/timer-keystone.c | 2

[PATCH -next] clocksource: keystone: Fix return value check in keystone_timer_init()

2014-01-16 Thread Wei Yongjun
From: Wei Yongjun In case of error, function of_clk_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/clocksource/timer-keystone.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH -next] clocksource: keystone: Fix return value check in keystone_timer_init()

2014-01-16 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, function of_clk_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

Re: [PATCH -next] clocksource: keystone: Fix return value check in keystone_timer_init()

2014-01-16 Thread Daniel Lezcano
On 01/16/2014 09:29 AM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, function of_clk_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun