Re: [PATCH -next] drm/i915: fix error return code in init_pipe_control()

2013-05-28 Thread Chris Wilson
On Tue, May 28, 2013 at 05:51:44PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return -ENOMEM in the kmap() error handling case > instead of 0, as done elsewhere in this function. kmap() can fail? It is either translated to page_address() or kmap_high() (on x86), neither of which

Re: [PATCH -next] drm/i915: fix error return code in init_pipe_control()

2013-05-28 Thread Daniel Vetter
On Tue, May 28, 2013 at 05:51:44PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return -ENOMEM in the kmap() error handling case > instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter

[PATCH -next] drm/i915: fix error return code in init_pipe_control()

2013-05-28 Thread Wei Yongjun
From: Wei Yongjun Fix to return -ENOMEM in the kmap() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/i915/intel_ringbuffer.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH -next] drm/i915: fix error return code in init_pipe_control()

2013-05-28 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENOMEM in the kmap() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/gpu/drm/i915/intel_ringbuffer.c | 6 -- 1 file changed, 4

Re: [PATCH -next] drm/i915: fix error return code in init_pipe_control()

2013-05-28 Thread Daniel Vetter
On Tue, May 28, 2013 at 05:51:44PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENOMEM in the kmap() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Queued for -next,

Re: [PATCH -next] drm/i915: fix error return code in init_pipe_control()

2013-05-28 Thread Chris Wilson
On Tue, May 28, 2013 at 05:51:44PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENOMEM in the kmap() error handling case instead of 0, as done elsewhere in this function. kmap() can fail? It is either translated to page_address() or kmap_high()