Re: [Intel-gfx] [PATCH -next] drm/i915: fix return value check of debugfs_create_file()

2013-12-16 Thread Damien Lespiau
On Mon, Dec 16, 2013 at 02:13:25PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function debugfs_create_file() returns NULL > pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test in > the return value check should be replaced with NULL test. > >

Re: [PATCH -next] drm/i915: fix return value check of debugfs_create_file()

2013-12-16 Thread Daniel Vetter
On Mon, Dec 16, 2013 at 02:13:25PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function debugfs_create_file() returns NULL > pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test in > the return value check should be replaced with NULL test. > >

Re: [PATCH -next] drm/i915: fix return value check of debugfs_create_file()

2013-12-16 Thread Daniel Vetter
On Mon, Dec 16, 2013 at 02:13:25PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function debugfs_create_file() returns NULL pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test in the return value check should be replaced with NULL

Re: [Intel-gfx] [PATCH -next] drm/i915: fix return value check of debugfs_create_file()

2013-12-16 Thread Damien Lespiau
On Mon, Dec 16, 2013 at 02:13:25PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function debugfs_create_file() returns NULL pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test in the return value check should be replaced with NULL

[PATCH -next] drm/i915: fix return value check of debugfs_create_file()

2013-12-15 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function debugfs_create_file() returns NULL pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/i915/i915_debugfs.c | 12 ++--

[PATCH -next] drm/i915: fix return value check of debugfs_create_file()

2013-12-15 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function debugfs_create_file() returns NULL pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn