Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

Hi Anton and Andrew, Hi Andrew, Ah, oops! Thank you and apologies. Quite right the alternative patch was even better. No need to apply this patch after all... Zheng, the log_page_mask variable was removed altogether so your patch no longer makes sense. Best regards, Anton On 1

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

Hi Andrew, Ah, oops! Thank you and apologies. Quite right the alternative patch was even better. No need to apply this patch after all... Zheng, the log_page_mask variable was removed altogether so your patch no longer makes sense. Best regards, Anton > On 10 Dec 2020, at 02:36, A

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

On Tue, 8 Dec 2020 08:24:02 + Anton Altaparmakov wrote: > Can you please apply this? > > ... > > > --- a/fs/ntfs/logfile.c > > +++ b/fs/ntfs/logfile.c > > @@ -507,7 +507,7 @@ bool ntfs_check_logfile(struct inode *log_vi, > > RESTART_PAGE_HEADER **rp) > > * optimize log_page_size and log

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

Hi Andrew, Can you please apply this? Thanks a lot in advance! Hi Zheng, Thank you for the patch! Best regards, Anton > On 12 Mar 2020, at 04:13, Zheng Zengkai wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > fs/ntfs/logfile.c: In function ntfs_check_logfile: > fs/ntf

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

Ping... Fixes gcc '-Wunused-but-set-variable' warning: fs/ntfs/logfile.c: In function ntfs_check_logfile: fs/ntfs/logfile.c:481:21: warning: variable log_page_mask set but not used [-Wunused-but-set-variable] Actually log_page_mask can be used to replace 'log_page_size - 1' as it is set. Sig