Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-11-03 Thread Eric W. Biederman
Jens Axboe writes: > On 11/2/20 1:31 PM, Jens Axboe wrote: >> On 11/2/20 1:12 PM, Eric W. Biederman wrote: >>> Jens Axboe writes: >>> On 11/2/20 12:27 PM, Eric W. Biederman wrote: > Jens Axboe writes: > >> On 10/30/20 4:22 PM, Al Viro wrote: >>> On Fri, Oct 30, 2020 at

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-11-02 Thread Jens Axboe
On 11/2/20 1:31 PM, Jens Axboe wrote: > On 11/2/20 1:12 PM, Eric W. Biederman wrote: >> Jens Axboe writes: >> >>> On 11/2/20 12:27 PM, Eric W. Biederman wrote: Jens Axboe writes: > On 10/30/20 4:22 PM, Al Viro wrote: >> On Fri, Oct 30, 2020 at 02:33:11PM -0600, Jens Axboe

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-11-02 Thread Jens Axboe
On 11/2/20 1:12 PM, Eric W. Biederman wrote: > Jens Axboe writes: > >> On 11/2/20 12:27 PM, Eric W. Biederman wrote: >>> Jens Axboe writes: >>> On 10/30/20 4:22 PM, Al Viro wrote: > On Fri, Oct 30, 2020 at 02:33:11PM -0600, Jens Axboe wrote: >> On 10/30/20 12:49 PM, Al Viro wrote:

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-11-02 Thread Eric W. Biederman
Jens Axboe writes: > On 11/2/20 12:27 PM, Eric W. Biederman wrote: >> Jens Axboe writes: >> >>> On 10/30/20 4:22 PM, Al Viro wrote: On Fri, Oct 30, 2020 at 02:33:11PM -0600, Jens Axboe wrote: > On 10/30/20 12:49 PM, Al Viro wrote: >> On Fri, Oct 30, 2020 at 12:46:26PM -0600, Jens

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-11-02 Thread Jens Axboe
On 11/2/20 12:27 PM, Eric W. Biederman wrote: > Jens Axboe writes: > >> On 10/30/20 4:22 PM, Al Viro wrote: >>> On Fri, Oct 30, 2020 at 02:33:11PM -0600, Jens Axboe wrote: On 10/30/20 12:49 PM, Al Viro wrote: > On Fri, Oct 30, 2020 at 12:46:26PM -0600, Jens Axboe wrote: > >> See

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-11-02 Thread Eric W. Biederman
Jens Axboe writes: > On 10/30/20 4:22 PM, Al Viro wrote: >> On Fri, Oct 30, 2020 at 02:33:11PM -0600, Jens Axboe wrote: >>> On 10/30/20 12:49 PM, Al Viro wrote: On Fri, Oct 30, 2020 at 12:46:26PM -0600, Jens Axboe wrote: > See other reply, it's being posted soon, just haven't

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-11-02 Thread Eric W. Biederman
Jens Axboe writes: > On 10/30/20 4:22 PM, Al Viro wrote: >> On Fri, Oct 30, 2020 at 02:33:11PM -0600, Jens Axboe wrote: >>> On 10/30/20 12:49 PM, Al Viro wrote: On Fri, Oct 30, 2020 at 12:46:26PM -0600, Jens Axboe wrote: > See other reply, it's being posted soon, just haven't

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-10-30 Thread Jens Axboe
On 10/30/20 4:22 PM, Al Viro wrote: > On Fri, Oct 30, 2020 at 02:33:11PM -0600, Jens Axboe wrote: >> On 10/30/20 12:49 PM, Al Viro wrote: >>> On Fri, Oct 30, 2020 at 12:46:26PM -0600, Jens Axboe wrote: >>> See other reply, it's being posted soon, just haven't gotten there yet and it

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-10-30 Thread Al Viro
On Fri, Oct 30, 2020 at 02:33:11PM -0600, Jens Axboe wrote: > On 10/30/20 12:49 PM, Al Viro wrote: > > On Fri, Oct 30, 2020 at 12:46:26PM -0600, Jens Axboe wrote: > > > >> See other reply, it's being posted soon, just haven't gotten there yet > >> and it wasn't ready. > >> > >> It's a prep patch

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-10-30 Thread Jens Axboe
On 10/30/20 12:49 PM, Al Viro wrote: > On Fri, Oct 30, 2020 at 12:46:26PM -0600, Jens Axboe wrote: > >> See other reply, it's being posted soon, just haven't gotten there yet >> and it wasn't ready. >> >> It's a prep patch so we can call do_renameat2 and pass in a filename >> instead. The intent

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-10-30 Thread Al Viro
On Fri, Oct 30, 2020 at 12:46:26PM -0600, Jens Axboe wrote: > See other reply, it's being posted soon, just haven't gotten there yet > and it wasn't ready. > > It's a prep patch so we can call do_renameat2 and pass in a filename > instead. The intent is not to have any functional changes in that

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-10-30 Thread Jens Axboe
On 10/30/20 12:42 PM, Al Viro wrote: > On Fri, Oct 30, 2020 at 11:24:07AM -0400, Qian Cai wrote: >> We will need to call putname() before do_renameat2() returning -EINVAL >> to avoid memory leaks. >> >> Fixes: 3c5499fa56f5 ("fs: make do_renameat2() take struct filename") >> Signed-off-by: Qian Cai

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-10-30 Thread Al Viro
On Fri, Oct 30, 2020 at 11:24:07AM -0400, Qian Cai wrote: > We will need to call putname() before do_renameat2() returning -EINVAL > to avoid memory leaks. > > Fixes: 3c5499fa56f5 ("fs: make do_renameat2() take struct filename") > Signed-off-by: Qian Cai May I ask where has the original commit

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-10-30 Thread Jens Axboe
On 10/30/20 9:52 AM, Qian Cai wrote: > On Fri, 2020-10-30 at 09:27 -0600, Jens Axboe wrote: >> On 10/30/20 9:24 AM, Qian Cai wrote: >>> We will need to call putname() before do_renameat2() returning -EINVAL >>> to avoid memory leaks. >> >> Thanks, should mention that this isn't final by any

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-10-30 Thread Qian Cai
On Fri, 2020-10-30 at 09:27 -0600, Jens Axboe wrote: > On 10/30/20 9:24 AM, Qian Cai wrote: > > We will need to call putname() before do_renameat2() returning -EINVAL > > to avoid memory leaks. > > Thanks, should mention that this isn't final by any stretch (which is > why it hasn't been posted

Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-10-30 Thread Jens Axboe
On 10/30/20 9:24 AM, Qian Cai wrote: > We will need to call putname() before do_renameat2() returning -EINVAL > to avoid memory leaks. Thanks, should mention that this isn't final by any stretch (which is why it hasn't been posted yet), just pushed out for some exposure. -- Jens Axboe

[PATCH -next] fs: Fix memory leaks in do_renameat2() error paths

2020-10-30 Thread Qian Cai
We will need to call putname() before do_renameat2() returning -EINVAL to avoid memory leaks. Fixes: 3c5499fa56f5 ("fs: make do_renameat2() take struct filename") Signed-off-by: Qian Cai --- fs/namei.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/fs/namei.c