Re: [PATCH -next] get_maintainer: Improve "Author:" rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 02:16 PM, Joe Perches wrote: > On Tue, 2013-11-05 at 14:04 +0800, Chen Gang wrote: >> On 11/05/2013 01:54 PM, Joe Perches wrote: >>> On Tue, 2013-11-05 at 13:45 +0800, Chen Gang wrote: > If really as what I guess above (some patches no Signed-of-by), is there > a tool to

Re: [PATCH -next] get_maintainer: Improve "Author:" rolestats

2013-11-04 Thread Joe Perches
On Tue, 2013-11-05 at 14:04 +0800, Chen Gang wrote: > On 11/05/2013 01:54 PM, Joe Perches wrote: > > On Tue, 2013-11-05 at 13:45 +0800, Chen Gang wrote: > >> > If really as what I guess above (some patches no Signed-of-by), is there > >> > a tool to check and find this issue in time? > >

Re: [PATCH -next] get_maintainer: Improve "Author:" rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 01:54 PM, Joe Perches wrote: > On Tue, 2013-11-05 at 13:45 +0800, Chen Gang wrote: >> > If really as what I guess above (some patches no Signed-of-by), is there >> > a tool to check and find this issue in time? > scripts/checkpatch.pl bleats a message on missing sign-offs. Yeah, the

Re: [PATCH -next] get_maintainer: Improve "Author:" rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 01:50 PM, Joe Perches wrote: > On Tue, 2013-11-05 at 13:42 +0800, Chen Gang wrote: >> On 11/05/2013 01:23 PM, Joe Perches wrote: >>> On Tue, 2013-11-05 at 10:37 +0800, Chen Gang wrote: > >> (if so, it seems the related >> patch need be re-committed again by the related author). > >

Re: [PATCH -next] get_maintainer: Improve "Author:" rolestats

2013-11-04 Thread Joe Perches
On Tue, 2013-11-05 at 13:45 +0800, Chen Gang wrote: > If really as what I guess above (some patches no Signed-of-by), is there > a tool to check and find this issue in time? scripts/checkpatch.pl bleats a message on missing sign-offs. For instance: $ cat cache.diff include/linux/cache.h | 4

Re: [PATCH -next] get_maintainer: Improve "Author:" rolestats

2013-11-04 Thread Joe Perches
On Tue, 2013-11-05 at 13:42 +0800, Chen Gang wrote: > On 11/05/2013 01:23 PM, Joe Perches wrote: > > On Tue, 2013-11-05 at 10:37 +0800, Chen Gang wrote: > >> But after I let it pure next-20131101 ("git reset HEAD^; git stash"), it > >> still cause this issue. > > > > It's also because: > > >

Re: [PATCH -next] get_maintainer: Improve "Author:" rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 01:42 PM, Chen Gang wrote: > On 11/05/2013 01:23 PM, Joe Perches wrote: >> On Tue, 2013-11-05 at 10:37 +0800, Chen Gang wrote: >>> But after I let it pure next-20131101 ("git reset HEAD^; git stash"), it >>> still cause this issue. >> >> It's also because: >> > Also, there's a

Re: [PATCH -next] get_maintainer: Improve "Author:" rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 01:23 PM, Joe Perches wrote: > On Tue, 2013-11-05 at 10:37 +0800, Chen Gang wrote: >> But after I let it pure next-20131101 ("git reset HEAD^; git stash"), it >> still cause this issue. > > It's also because: > Also, there's a defect in function vcs_find_signers. It

Re: [PATCH -next] get_maintainer: Improve "Author:" rolestats

2013-11-04 Thread Joe Perches
On Tue, 2013-11-05 at 10:37 +0800, Chen Gang wrote: > But after I let it pure next-20131101 ("git reset HEAD^; git stash"), it > still cause this issue. It's also because: > >> Also, there's a defect in function vcs_find_signers. > >> It should only return the commit count and array references.

Re: [PATCH -next] get_maintainer: Improve "Author:" rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 10:22 AM, Chen Gang wrote: > On 11/05/2013 05:54 AM, Joe Perches wrote: >> Add this to "try this"... >> >> Chen Gang's defect is because his git repository branch >> had a commit he authored but where did not add his signature. >> Hmm... in fact, when I make a patch, I really let

Re: [PATCH -next] get_maintainer: Improve "Author:" rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 05:54 AM, Joe Perches wrote: > Add this to "try this"... > > Chen Gang's defect is because his git repository branch > had a commit he authored but where did not add his signature. > Hmm... for pure next-20131101 tree in my git directory and the demo patches in attachment, it will

[PATCH -next] get_maintainer: Improve "Author:" rolestats

2013-11-04 Thread Joe Perches
Add this to "try this"... Chen Gang's defect is because his git repository branch had a commit he authored but where did not add his signature. Also, there's a defect in function vcs_find_signers. It should only return the commit count and array references. If there are no signers in the commit

[PATCH -next] get_maintainer: Improve Author: rolestats

2013-11-04 Thread Joe Perches
Add this to try this... Chen Gang's defect is because his git repository branch had a commit he authored but where did not add his signature. Also, there's a defect in function vcs_find_signers. It should only return the commit count and array references. If there are no signers in the commit

Re: [PATCH -next] get_maintainer: Improve Author: rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 05:54 AM, Joe Perches wrote: Add this to try this... Chen Gang's defect is because his git repository branch had a commit he authored but where did not add his signature. Hmm... for pure next-20131101 tree in my git directory and the demo patches in attachment, it will cause

Re: [PATCH -next] get_maintainer: Improve Author: rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 10:22 AM, Chen Gang wrote: On 11/05/2013 05:54 AM, Joe Perches wrote: Add this to try this... Chen Gang's defect is because his git repository branch had a commit he authored but where did not add his signature. Hmm... in fact, when I make a patch, I really let git log

Re: [PATCH -next] get_maintainer: Improve Author: rolestats

2013-11-04 Thread Joe Perches
On Tue, 2013-11-05 at 10:37 +0800, Chen Gang wrote: But after I let it pure next-20131101 (git reset HEAD^; git stash), it still cause this issue. It's also because: Also, there's a defect in function vcs_find_signers. It should only return the commit count and array references. If

Re: [PATCH -next] get_maintainer: Improve Author: rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 01:23 PM, Joe Perches wrote: On Tue, 2013-11-05 at 10:37 +0800, Chen Gang wrote: But after I let it pure next-20131101 (git reset HEAD^; git stash), it still cause this issue. It's also because: Also, there's a defect in function vcs_find_signers. It should only return the

Re: [PATCH -next] get_maintainer: Improve Author: rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 01:42 PM, Chen Gang wrote: On 11/05/2013 01:23 PM, Joe Perches wrote: On Tue, 2013-11-05 at 10:37 +0800, Chen Gang wrote: But after I let it pure next-20131101 (git reset HEAD^; git stash), it still cause this issue. It's also because: Also, there's a defect in function

Re: [PATCH -next] get_maintainer: Improve Author: rolestats

2013-11-04 Thread Joe Perches
On Tue, 2013-11-05 at 13:42 +0800, Chen Gang wrote: On 11/05/2013 01:23 PM, Joe Perches wrote: On Tue, 2013-11-05 at 10:37 +0800, Chen Gang wrote: But after I let it pure next-20131101 (git reset HEAD^; git stash), it still cause this issue. It's also because: Also, there's a

Re: [PATCH -next] get_maintainer: Improve Author: rolestats

2013-11-04 Thread Joe Perches
On Tue, 2013-11-05 at 13:45 +0800, Chen Gang wrote: If really as what I guess above (some patches no Signed-of-by), is there a tool to check and find this issue in time? scripts/checkpatch.pl bleats a message on missing sign-offs. For instance: $ cat cache.diff include/linux/cache.h | 4 ++--

Re: [PATCH -next] get_maintainer: Improve Author: rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 01:50 PM, Joe Perches wrote: On Tue, 2013-11-05 at 13:42 +0800, Chen Gang wrote: On 11/05/2013 01:23 PM, Joe Perches wrote: On Tue, 2013-11-05 at 10:37 +0800, Chen Gang wrote: (if so, it seems the related patch need be re-committed again by the related author). No it

Re: [PATCH -next] get_maintainer: Improve Author: rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 01:54 PM, Joe Perches wrote: On Tue, 2013-11-05 at 13:45 +0800, Chen Gang wrote: If really as what I guess above (some patches no Signed-of-by), is there a tool to check and find this issue in time? scripts/checkpatch.pl bleats a message on missing sign-offs. Yeah, the

Re: [PATCH -next] get_maintainer: Improve Author: rolestats

2013-11-04 Thread Joe Perches
On Tue, 2013-11-05 at 14:04 +0800, Chen Gang wrote: On 11/05/2013 01:54 PM, Joe Perches wrote: On Tue, 2013-11-05 at 13:45 +0800, Chen Gang wrote: If really as what I guess above (some patches no Signed-of-by), is there a tool to check and find this issue in time? scripts/checkpatch.pl

Re: [PATCH -next] get_maintainer: Improve Author: rolestats

2013-11-04 Thread Chen Gang
On 11/05/2013 02:16 PM, Joe Perches wrote: On Tue, 2013-11-05 at 14:04 +0800, Chen Gang wrote: On 11/05/2013 01:54 PM, Joe Perches wrote: On Tue, 2013-11-05 at 13:45 +0800, Chen Gang wrote: If really as what I guess above (some patches no Signed-of-by), is there a tool to check and find this