Re: [PATCH -next] ipc: use GFP_ATOMIC under spin lock

2020-04-29 Thread Matthew Wilcox
On Wed, Apr 29, 2020 at 07:22:13AM +0200, Manfred Spraul wrote: > Hello together, > > On 4/28/20 1:14 PM, Matthew Wilcox wrote: > > On Tue, Apr 28, 2020 at 03:47:36AM +, Wei Yongjun wrote: > > > The function ipc_id_alloc() is called from ipc_addid(), in which > > > a spin lock is held, so we

Re: [PATCH -next] ipc: use GFP_ATOMIC under spin lock

2020-04-28 Thread Manfred Spraul
Hello together, On 4/28/20 1:14 PM, Matthew Wilcox wrote: On Tue, Apr 28, 2020 at 03:47:36AM +, Wei Yongjun wrote: The function ipc_id_alloc() is called from ipc_addid(), in which a spin lock is held, so we should use GFP_ATOMIC instead. Fixes: de5738d1c364 ("ipc: convert ipcs_idr to

Re: [PATCH -next] ipc: use GFP_ATOMIC under spin lock

2020-04-28 Thread Matthew Wilcox
On Tue, Apr 28, 2020 at 05:14:20PM -0700, Andrew Morton wrote: > On Tue, 28 Apr 2020 04:14:03 -0700 Matthew Wilcox wrote: > > > On Tue, Apr 28, 2020 at 03:47:36AM +, Wei Yongjun wrote: > > > The function ipc_id_alloc() is called from ipc_addid(), in which > > > a spin lock is held, so we

Re: [PATCH -next] ipc: use GFP_ATOMIC under spin lock

2020-04-28 Thread Andrew Morton
On Tue, 28 Apr 2020 04:14:03 -0700 Matthew Wilcox wrote: > On Tue, Apr 28, 2020 at 03:47:36AM +, Wei Yongjun wrote: > > The function ipc_id_alloc() is called from ipc_addid(), in which > > a spin lock is held, so we should use GFP_ATOMIC instead. > > > > Fixes: de5738d1c364 ("ipc: convert

Re: [PATCH -next] ipc: use GFP_ATOMIC under spin lock

2020-04-28 Thread Matthew Wilcox
On Tue, Apr 28, 2020 at 03:47:36AM +, Wei Yongjun wrote: > The function ipc_id_alloc() is called from ipc_addid(), in which > a spin lock is held, so we should use GFP_ATOMIC instead. > > Fixes: de5738d1c364 ("ipc: convert ipcs_idr to XArray") > Signed-off-by: Wei Yongjun I see why you