Re: [PATCH -next] lib/vsprintf: Make function pointer_string static

2019-04-30 Thread Petr Mladek
On Mon 2019-04-29 09:42:30, Joe Perches wrote: > On Mon, 2019-04-29 at 10:39 -0400, Steven Rostedt wrote: > > [ added Joe ] > > > Good question. I have just double checked it. And pointer_string() with > > > "noinline_for_stack" does not make any difference in the stack > > > usage here. > > > >

Re: [PATCH -next] lib/vsprintf: Make function pointer_string static

2019-04-29 Thread Joe Perches
On Mon, 2019-04-29 at 10:39 -0400, Steven Rostedt wrote: > [ added Joe ] > > Good question. I have just double checked it. And pointer_string() with > > "noinline_for_stack" does not make any difference in the stack > > usage here. > > > > I actually played with this before: > > > >

Re: [PATCH -next] lib/vsprintf: Make function pointer_string static

2019-04-29 Thread Steven Rostedt
[ added Joe ] On Mon, 29 Apr 2019 16:30:37 +0200 Petr Mladek wrote: > On Mon 2019-04-29 09:13:20, Steven Rostedt wrote: > > On Mon, 29 Apr 2019 13:08:01 +0200 > > Petr Mladek wrote: > > > > > > Looks like commit "vsprintf: Do not check address of well-known > > > > strings" removed the:

Re: [PATCH -next] lib/vsprintf: Make function pointer_string static

2019-04-29 Thread Petr Mladek
On Mon 2019-04-29 09:13:20, Steven Rostedt wrote: > On Mon, 29 Apr 2019 13:08:01 +0200 > Petr Mladek wrote: > > > > Looks like commit "vsprintf: Do not check address of well-known > > > strings" removed the: "static noinline_for_stack" > > > > > > Does pointer_string() need that still? > > >

Re: [PATCH -next] lib/vsprintf: Make function pointer_string static

2019-04-29 Thread Steven Rostedt
On Mon, 29 Apr 2019 13:08:01 +0200 Petr Mladek wrote: > > Looks like commit "vsprintf: Do not check address of well-known > > strings" removed the: "static noinline_for_stack" > > > > Does pointer_string() need that still? > > Heh, it was removed by mistake and well hidden in the diff. > >

Re: [PATCH -next] lib/vsprintf: Make function pointer_string static

2019-04-29 Thread Petr Mladek
On Fri 2019-04-26 13:02:04, Steven Rostedt wrote: > On Sat, 27 Apr 2019 00:46:30 +0800 > Yue Haibing wrote: > > > From: YueHaibing > > > > Fix sparse warning: > > > > lib/vsprintf.c:673:6: warning: > > symbol 'pointer_string' was not declared. Should it be static? > > > > Signed-off-by:

Re: [PATCH -next] lib/vsprintf: Make function pointer_string static

2019-04-26 Thread Steven Rostedt
On Sat, 27 Apr 2019 00:46:30 +0800 Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > lib/vsprintf.c:673:6: warning: > symbol 'pointer_string' was not declared. Should it be static? > > Signed-off-by: YueHaibing > --- > lib/vsprintf.c | 5 +++-- > 1 file changed, 3

[PATCH -next] lib/vsprintf: Make function pointer_string static

2019-04-26 Thread Yue Haibing
From: YueHaibing Fix sparse warning: lib/vsprintf.c:673:6: warning: symbol 'pointer_string' was not declared. Should it be static? Signed-off-by: YueHaibing --- lib/vsprintf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index