Re: [PATCH -next] lockd: Make two symbols static

2019-05-28 Thread Chuck Lever
> On May 28, 2019, at 11:13 AM, J. Bruce Fields wrote: > > On Tue, May 28, 2019 at 06:49:13AM -0400, Benjamin Coddington wrote: >> Maintainers, what's the best thing to do here: fold these into >> another patch version and post it (add attribution)? Add it as >> another patch at the end of th

Re: [PATCH -next] lockd: Make two symbols static

2019-05-28 Thread J. Bruce Fields
On Tue, May 28, 2019 at 06:49:13AM -0400, Benjamin Coddington wrote: > Maintainers, what's the best thing to do here: fold these into > another patch version and post it (add attribution)? Add it as > another patch at the end of the series? Either would be fine. Yeah, if it was folded in then we

Re: [PATCH -next] lockd: Make two symbols static

2019-05-28 Thread Benjamin Coddington
Maintainers, what's the best thing to do here: fold these into another patch version and post it (add attribution)? Add it as another patch at the end of the series? I have learned my lesson: add sparse to my workflow. Ben On 28 May 2019, at 5:06, YueHaibing wrote: Fix sparse warnings: fs

[PATCH -next] lockd: Make two symbols static

2019-05-28 Thread YueHaibing
Fix sparse warnings: fs/lockd/clntproc.c:57:6: warning: symbol 'nlmclnt_put_lockowner' was not declared. Should it be static? fs/lockd/svclock.c:409:35: warning: symbol 'nlmsvc_lock_ops' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- fs/lockd/cln