Re: [PATCH -next] mm: Mark 'stack_vm_area' with __maybe_unused

2019-01-03 Thread Michal Hocko
On Wed 02-01-19 19:40:15, YueHaibing wrote: > On 2019/1/2 18:55, Dan Carpenter wrote: > > On Fri, Dec 28, 2018 at 09:58:04AM +0100, Michal Hocko wrote: > >> On Fri 28-12-18 02:46:30, YueHaibing wrote: > >>> Fixes gcc '-Wunused-but-set-variable' warning when > >>> CONFIG_VMAP_STACK is not set: > >>

Re: [PATCH -next] mm: Mark 'stack_vm_area' with __maybe_unused

2019-01-02 Thread YueHaibing
On 2019/1/2 18:55, Dan Carpenter wrote: > On Fri, Dec 28, 2018 at 09:58:04AM +0100, Michal Hocko wrote: >> On Fri 28-12-18 02:46:30, YueHaibing wrote: >>> Fixes gcc '-Wunused-but-set-variable' warning when >>> CONFIG_VMAP_STACK is not set: >> >> Isn't this warning disabled? I can see the following

Re: [PATCH -next] mm: Mark 'stack_vm_area' with __maybe_unused

2019-01-02 Thread Dan Carpenter
On Fri, Dec 28, 2018 at 09:58:04AM +0100, Michal Hocko wrote: > On Fri 28-12-18 02:46:30, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning when > > CONFIG_VMAP_STACK is not set: > > Isn't this warning disabled? I can see the following > # These warnings generated too much noise

Re: [PATCH -next] mm: Mark 'stack_vm_area' with __maybe_unused

2018-12-28 Thread Michal Hocko
On Fri 28-12-18 02:46:30, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning when > CONFIG_VMAP_STACK is not set: Isn't this warning disabled? I can see the following # These warnings generated too much noise in a regular build. # Use make W=1 to enable them (see scripts/Makefile.ex

[PATCH -next] mm: Mark 'stack_vm_area' with __maybe_unused

2018-12-27 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning when CONFIG_VMAP_STACK is not set: kernel/fork.c: In function 'dup_task_struct': kernel/fork.c:843:20: warning: variable 'stack_vm_area' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing --- kernel/fork.c | 2 +- 1 file changed