Re: [PATCH -next] regulator: rt4831: Fix return value check in rt4831_regulator_probe()

2021-03-10 Thread 黃啟原
Many thanks to fix it. I didn't notice this fault. > dev_err(>dev, "Failed to init regmap\n"); > -return PTR_ERR(regmap); > +return -ENODEV; > } > > /* Configure DSV mode to normal by default */ > * Email Confidentiality Notice The information contained in this

Re: [PATCH -next] regulator: rt4831: Fix return value check in rt4831_regulator_probe()

2021-03-08 Thread Mark Brown
On Fri, 5 Mar 2021 03:49:30 +, 'Wei Yongjun wrote: > In case of error, the function dev_get_regmap() returns NULL > pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test. Applied to

[PATCH -next] regulator: rt4831: Fix return value check in rt4831_regulator_probe()

2021-03-04 Thread 'Wei Yongjun
From: Wei Yongjun In case of error, the function dev_get_regmap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 9351ab8b0cb6 ("regulator: rt4831: Adds support for Richtek RT4831 DSV regulator") Reported-by: Hulk Robot