Re: [PATCH -next] remoteproc: k3-dsp: Fix return value check in k3_dsp_rproc_of_get_memories()

2020-09-04 Thread Suman Anna
On 9/2/20 11:59 AM, Mathieu Poirier wrote: > On Wed, Sep 02, 2020 at 10:06:14PM +0800, YueHaibing wrote: >> In case of error, the function devm_ioremap_wc() returns NULL pointer >> not ERR_PTR(). The IS_ERR() test in the return value check should be >> replaced with NULL test. >> >> Fixes:

Re: [PATCH -next] remoteproc: k3-dsp: Fix return value check in k3_dsp_rproc_of_get_memories()

2020-09-02 Thread Mathieu Poirier
On Wed, Sep 02, 2020 at 10:06:14PM +0800, YueHaibing wrote: > In case of error, the function devm_ioremap_wc() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. > > Fixes: 87218f96c21a ("remoteproc: k3-dsp: Add support for C71x

Re: [PATCH -next] remoteproc: k3-dsp: Fix return value check in k3_dsp_rproc_of_get_memories()

2020-09-02 Thread Suman Anna
On 9/2/20 9:06 AM, YueHaibing wrote: > In case of error, the function devm_ioremap_wc() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. Thanks for the fix. > > Fixes: 87218f96c21a ("remoteproc: k3-dsp: Add support for C71x

[PATCH -next] remoteproc: k3-dsp: Fix return value check in k3_dsp_rproc_of_get_memories()

2020-09-02 Thread YueHaibing
In case of error, the function devm_ioremap_wc() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 87218f96c21a ("remoteproc: k3-dsp: Add support for C71x DSPs") Signed-off-by: YueHaibing ---