Re: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE

2019-08-29 Thread Bruno Thomsen
Den ons. 28. aug. 2019 kl. 19.19 skrev Randy Dunlap : > > Definitively not, I fixed it that way: > > + select WATCHDOG_CORE if WATCHDOG > > > > No, that's not a fix. The build error still happens with that patch applied. Hi Randy, A bugfix has been created[1] and applied to the rtc tree.

Re: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE

2019-08-28 Thread Randy Dunlap
On 8/23/19 7:05 AM, Alexandre Belloni wrote: > On 23/08/2019 20:45:53+0800, YueHaibing wrote: >> If WATCHDOG_CORE is not set, build fails: >> >> drivers/rtc/rtc-pcf2127.o: In function `pcf2127_probe.isra.6': >> drivers/rtc/rtc-pcf2127.c:478: undefined reference to >> `devm_watchdog_register_device

Re: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE

2019-08-26 Thread Guenter Roeck
On Mon, Aug 26, 2019 at 08:13:35PM +0200, Bruno Thomsen wrote: > Den man. 26. aug. 2019 kl. 15.20 skrev Guenter Roeck : > > > > On 8/26/19 1:12 AM, Yuehaibing wrote: > > > > > > > > > On 2019/8/23 22:05, Alexandre Belloni wrote: > > >> On 23/08/2019 20:45:53+0800, YueHaibing wrote: > > >>> If WATCH

Re: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE

2019-08-26 Thread Bruno Thomsen
Den man. 26. aug. 2019 kl. 15.20 skrev Guenter Roeck : > > On 8/26/19 1:12 AM, Yuehaibing wrote: > > > > > > On 2019/8/23 22:05, Alexandre Belloni wrote: > >> On 23/08/2019 20:45:53+0800, YueHaibing wrote: > >>> If WATCHDOG_CORE is not set, build fails: > >>> > >>> drivers/rtc/rtc-pcf2127.o: In fun

Re: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE

2019-08-26 Thread Guenter Roeck
On 8/26/19 1:12 AM, Yuehaibing wrote: On 2019/8/23 22:05, Alexandre Belloni wrote: On 23/08/2019 20:45:53+0800, YueHaibing wrote: If WATCHDOG_CORE is not set, build fails: drivers/rtc/rtc-pcf2127.o: In function `pcf2127_probe.isra.6': drivers/rtc/rtc-pcf2127.c:478: undefined reference to `d

Re: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE

2019-08-26 Thread Yuehaibing
On 2019/8/23 22:05, Alexandre Belloni wrote: > On 23/08/2019 20:45:53+0800, YueHaibing wrote: >> If WATCHDOG_CORE is not set, build fails: >> >> drivers/rtc/rtc-pcf2127.o: In function `pcf2127_probe.isra.6': >> drivers/rtc/rtc-pcf2127.c:478: undefined reference to >> `devm_watchdog_register_dev

Re: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE

2019-08-23 Thread Alexandre Belloni
On 23/08/2019 20:45:53+0800, YueHaibing wrote: > If WATCHDOG_CORE is not set, build fails: > > drivers/rtc/rtc-pcf2127.o: In function `pcf2127_probe.isra.6': > drivers/rtc/rtc-pcf2127.c:478: undefined reference to > `devm_watchdog_register_device' > > Add WATCHDOG_CORE Kconfig dependency to fix

Re: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE

2019-08-23 Thread Guenter Roeck
On 8/23/19 5:45 AM, YueHaibing wrote: If WATCHDOG_CORE is not set, build fails: drivers/rtc/rtc-pcf2127.o: In function `pcf2127_probe.isra.6': drivers/rtc/rtc-pcf2127.c:478: undefined reference to `devm_watchdog_register_device' Add WATCHDOG_CORE Kconfig dependency to fix this. Reported-by: H

[PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE

2019-08-23 Thread YueHaibing
If WATCHDOG_CORE is not set, build fails: drivers/rtc/rtc-pcf2127.o: In function `pcf2127_probe.isra.6': drivers/rtc/rtc-pcf2127.c:478: undefined reference to `devm_watchdog_register_device' Add WATCHDOG_CORE Kconfig dependency to fix this. Reported-by: Hulk Robot Fixes: bbc597561ce1 ("rtc: pc