Re: [PATCH -next] slub: Replace __this_cpu_inc usage w/ SLUB_STATS

2014-04-14 Thread Christoph Lameter
On Mon, 14 Apr 2014, Johannes Hirte wrote: > kernel/watchdog.c: > > void touch_softlockup_watchdog(void) > { > __this_cpu_write(watchdog_touch_ts, 0); > } > EXPORT_SYMBOL(touch_softlockup_watchdog); > > Don't know if the change to this_cpu_write() is the right way here too. Well yes lets

Re: [PATCH -next] slub: Replace __this_cpu_inc usage w/ SLUB_STATS

2014-04-14 Thread Johannes Hirte
On Thu, 6 Mar 2014 12:29:41 -0600 Josh Cartwright wrote: > On Thu, Mar 06, 2014 at 09:53:16AM -0600, Josh Cartwright wrote: > > Booting on my Samsung Series 9 laptop gives me loads and loads of > > BUGs triggered by __this_cpu_add(), making making the system > > completely unusable: > > > > [

Re: [PATCH -next] slub: Replace __this_cpu_inc usage w/ SLUB_STATS

2014-04-14 Thread Johannes Hirte
On Thu, 6 Mar 2014 12:29:41 -0600 Josh Cartwright jo...@codeaurora.org wrote: On Thu, Mar 06, 2014 at 09:53:16AM -0600, Josh Cartwright wrote: Booting on my Samsung Series 9 laptop gives me loads and loads of BUGs triggered by __this_cpu_add(), making making the system completely unusable:

Re: [PATCH -next] slub: Replace __this_cpu_inc usage w/ SLUB_STATS

2014-04-14 Thread Christoph Lameter
On Mon, 14 Apr 2014, Johannes Hirte wrote: kernel/watchdog.c: void touch_softlockup_watchdog(void) { __this_cpu_write(watchdog_touch_ts, 0); } EXPORT_SYMBOL(touch_softlockup_watchdog); Don't know if the change to this_cpu_write() is the right way here too. Well yes lets change

Re: [PATCH -next] slub: Replace __this_cpu_inc usage w/ SLUB_STATS

2014-03-07 Thread Christoph Lameter
On Thu, 6 Mar 2014, Josh Cartwright wrote: > Although, I'm wondering how exact these statistics need to be. Is > making them preemption safe even a concern? Not sure about that. You solution makes it preempt safe. If is can be tolerated that its racy then raw_cpu_inc() could be used. -- To

Re: [PATCH -next] slub: Replace __this_cpu_inc usage w/ SLUB_STATS

2014-03-07 Thread Christoph Lameter
On Thu, 6 Mar 2014, Josh Cartwright wrote: Although, I'm wondering how exact these statistics need to be. Is making them preemption safe even a concern? Not sure about that. You solution makes it preempt safe. If is can be tolerated that its racy then raw_cpu_inc() could be used. -- To

[PATCH -next] slub: Replace __this_cpu_inc usage w/ SLUB_STATS

2014-03-06 Thread Josh Cartwright
On Thu, Mar 06, 2014 at 09:53:16AM -0600, Josh Cartwright wrote: > Booting on my Samsung Series 9 laptop gives me loads and loads of BUGs > triggered by __this_cpu_add(), making making the system completely > unusable: > > [5.808326] BUG: using __this_cpu_add() in preemptible [] code:

[PATCH -next] slub: Replace __this_cpu_inc usage w/ SLUB_STATS

2014-03-06 Thread Josh Cartwright
On Thu, Mar 06, 2014 at 09:53:16AM -0600, Josh Cartwright wrote: Booting on my Samsung Series 9 laptop gives me loads and loads of BUGs triggered by __this_cpu_add(), making making the system completely unusable: [5.808326] BUG: using __this_cpu_add() in preemptible [] code: